Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor JSON.parse #1535

Merged
merged 2 commits into from Sep 15, 2021
Merged

Refactor JSON.parse #1535

merged 2 commits into from Sep 15, 2021

Conversation

raskad
Copy link
Member

@raskad raskad commented Aug 29, 2021

Fixes the new test failure from #1528.

It changes the following:

  • Refactor JSON.parse

@raskad
Copy link
Member Author

raskad commented Aug 29, 2021

Test262 conformance changes:

Test result master count PR count difference
Total 80,804 80,804 0
Passed 33,162 33,172 +10
Ignored 15,896 15,896 0
Failed 31,746 31,736 -10
Panics 0 0 0
Conformance 41.04% 41.05% +0.01%
Fixed tests (10):
test/built-ins/JSON/parse/reviver-get-name-err.js [strict mode] (previously Failed)
test/built-ins/JSON/parse/reviver-get-name-err.js (previously Failed)
test/built-ins/JSON/parse/reviver-object-non-configurable-prop-delete.js [strict mode] (previously Failed)
test/built-ins/JSON/parse/reviver-object-non-configurable-prop-delete.js (previously Failed)
test/built-ins/JSON/parse/reviver-object-non-configurable-prop-create.js [strict mode] (previously Failed)
test/built-ins/JSON/parse/reviver-object-non-configurable-prop-create.js (previously Failed)
test/built-ins/JSON/parse/reviver-call-order.js [strict mode] (previously Failed)
test/built-ins/JSON/parse/reviver-call-order.js (previously Failed)
test/built-ins/JSON/parse/reviver-array-get-prop-from-prototype.js [strict mode] (previously Failed)
test/built-ins/JSON/parse/reviver-array-get-prop-from-prototype.js (previously Failed)

@raskad raskad added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Aug 29, 2021
boa/src/builtins/json/mod.rs Outdated Show resolved Hide resolved
boa/src/builtins/json/mod.rs Show resolved Hide resolved
@raskad raskad requested a review from jedel1043 August 30, 2021 20:34
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. Good work!

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@HalidOdat
Copy link
Member

Just needs a rebase.

@raskad raskad merged commit e4226c8 into boa-dev:master Sep 15, 2021
@raskad raskad added this to the v0.13.0 milestone Sep 15, 2021
@raskad raskad deleted the json-parse branch September 15, 2021 21:38
@raskad raskad mentioned this pull request Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants