Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/number object #182

Merged
merged 5 commits into from
Nov 6, 2019
Merged

Feature/number object #182

merged 5 commits into from
Nov 6, 2019

Commits on Nov 5, 2019

  1. Feature: Skeleton code for Number 

    refs boa-dev#34
    @pop
    pop committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    ef2dcfd View commit details
    Browse the repository at this point in the history

  2. Feature(Number): Tests for the Test Driven Development! 

    refs boa-dev#34
    @pop
    pop committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    9406aa8 View commit details
    Browse the repository at this point in the history

  3. Feature: Most of Number() is complete 

    Includes:
- make_number()
- call_number()
- Number().toExponential()
- Number().toFixed()
- Number().toLocaleString() (ish)
- Number().toString()
- Number().valueOf()
- create_constructor()
- init()

Missing:
- Number().toPrecision()

refs boa-dev#34
    @pop
    pop committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    6b61642 View commit details
    Browse the repository at this point in the history

  4. Feature(Number): test compatability with const -> var 

    I don't have all the context on _why_ but all of the tests for `Number` started failing.

Upon investigation it was becuase `const` stopped acting the way I expected.
Switching my test cases from using `const` to using `var` variable declarations
made everything work again.  I don't know enough about JS to know if this is a
bug or expected behavior.  Based on changes to other tests, it is know
behavior.

Refs boa-dev#34
    @pop
    pop committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    340291d View commit details
    Browse the repository at this point in the history

  5. Changelog: Number() object. 

    Includes some clippy fixes.

Fixes boa-dev#34
    @pop
    pop committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    1796146 View commit details
    Browse the repository at this point in the history