Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix link to the playground #1947

Closed
wants to merge 1 commit into from

Conversation

raskad
Copy link
Member

@raskad raskad commented Mar 16, 2022

Fixes the link to the playground in the Readme

@raskad raskad added bug Something isn't working documentation update documentation labels Mar 16, 2022
@Razican
Copy link
Member

Razican commented Mar 16, 2022

Bors r+

@RageKnify
Copy link
Member

bors r+

@HalidOdat
Copy link
Member

Ummm... bors seems to not be working.

@bors
Copy link

bors bot commented Mar 16, 2022

🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@github-actions
Copy link

Test262 conformance changes

VM implementation

Test result main count PR count difference
Total 88,428 88,428 0
Passed 43,986 43,986 0
Ignored 21,495 21,495 0
Failed 22,947 22,947 0
Panics 0 0 0
Conformance 49.74% 49.74% 0.00%

@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #1947 (860e8a2) into main (ebf2bc6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1947   +/-   ##
=======================================
  Coverage   45.87%   45.87%           
=======================================
  Files         206      206           
  Lines       17102    17102           
=======================================
  Hits         7846     7846           
  Misses       9256     9256           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebf2bc6...860e8a2. Read the comment docs.

bors bot pushed a commit that referenced this pull request Mar 16, 2022
Fixes the link to the playground in the Readme
@github-actions
Copy link

Benchmark for 874d17e

Click to view benchmark
Test Base PR %
Arithmetic operations (Compiler) 792.9±38.25ns 695.0±58.19ns -12.35%
Arithmetic operations (Execution) 2.5±0.14µs 2.4±0.17µs -4.00%
Arithmetic operations (Parser) 6.0±0.47µs 6.4±0.30µs +6.67%
Array access (Compiler) 1846.6±77.99ns 1692.5±147.86ns -8.35%
Array access (Execution) 12.7±1.03µs 12.4±0.64µs -2.36%
Array access (Parser) 13.6±1.96µs 14.3±0.58µs +5.15%
Array creation (Compiler) 2.5±0.11µs 2.5±0.12µs 0.00%
Array creation (Execution) 4.0±0.18ms 3.6±0.27ms -10.00%
Array creation (Parser) 14.6±1.13µs 15.9±0.56µs +8.90%
Array pop (Compiler) 4.8±0.30µs 5.1±0.89µs +6.25%
Array pop (Execution) 1729.1±194.71µs 1532.2±100.20µs -11.39%
Array pop (Parser) 158.1±12.22µs 167.4±12.78µs +5.88%
Boolean Object Access (Compiler) 1516.4±80.77ns 1446.8±72.73ns -4.59%
Boolean Object Access (Execution) 7.4±0.52µs 7.7±2.53µs +4.05%
Boolean Object Access (Parser) 15.3±0.97µs 16.6±1.35µs +8.50%
Clean js (Compiler) 4.6±0.17µs 4.2±0.45µs -8.70%
Clean js (Execution) 1292.1±80.41µs 1369.4±69.08µs +5.98%
Clean js (Parser) 31.8±4.24µs 32.2±1.77µs +1.26%
Create Realm 318.8±26.79ns 343.8±68.03ns +7.84%
Dynamic Object Property Access (Compiler) 2.1±0.13µs 2.1±0.15µs 0.00%
Dynamic Object Property Access (Execution) 9.1±0.43µs 8.9±0.76µs -2.20%
Dynamic Object Property Access (Parser) 12.8±0.63µs 12.7±0.32µs -0.78%
Fibonacci (Compiler) 2.9±0.27µs 3.0±0.28µs +3.45%
Fibonacci (Execution) 2.4±0.12ms 2.3±0.10ms -4.17%
Fibonacci (Parser) 18.3±1.62µs 20.1±4.39µs +9.84%
For loop (Compiler) 2.5±0.25µs 2.6±0.18µs +4.00%
For loop (Execution) 54.2±2.48µs 51.1±3.06µs -5.72%
For loop (Parser) 15.4±1.47µs 16.2±0.56µs +5.19%
Mini js (Compiler) 4.5±0.66µs 4.0±0.28µs -11.11%
Mini js (Execution) 1198.6±54.81µs 1203.1±66.69µs +0.38%
Mini js (Parser) 27.9±2.05µs 30.2±2.83µs +8.24%
Number Object Access (Compiler) 1368.9±79.31ns 1304.0±56.68ns -4.74%
Number Object Access (Execution) 5.9±0.26µs 5.8±0.37µs -1.69%
Number Object Access (Parser) 11.9±0.93µs 13.4±0.47µs +12.61%
Object Creation (Compiler) 1802.8±156.51ns 1875.2±83.70ns +4.02%
Object Creation (Execution) 7.9±0.31µs 7.6±0.51µs -3.80%
Object Creation (Parser) 10.8±0.79µs 11.1±0.42µs +2.78%
RegExp (Compiler) 2.3±0.11µs 2.1±0.18µs -8.70%
RegExp (Execution) 16.2±0.82µs 16.3±3.23µs +0.62%
RegExp (Parser) 11.4±0.82µs 11.9±0.63µs +4.39%
RegExp Creation (Compiler) 1880.4±218.32ns 1812.5±106.56ns -3.61%
RegExp Creation (Execution) 11.7±0.58µs 11.3±0.54µs -3.42%
RegExp Creation (Parser) 9.6±0.67µs 10.1±0.44µs +5.21%
RegExp Literal (Compiler) 2.3±0.17µs 2.1±0.16µs -8.70%
RegExp Literal (Execution) 15.8±0.47µs 15.6±0.71µs -1.27%
RegExp Literal (Parser) 9.3±0.72µs 9.7±0.47µs +4.30%
RegExp Literal Creation (Compiler) 1901.2±170.47ns 1841.1±154.77ns -3.16%
RegExp Literal Creation (Execution) 11.9±0.62µs 11.8±0.49µs -0.84%
RegExp Literal Creation (Parser) 7.1±0.45µs 7.8±0.33µs +9.86%
Static Object Property Access (Compiler) 1873.6±141.97ns 1884.7±90.84ns +0.59%
Static Object Property Access (Execution) 8.2±0.42µs 7.9±0.38µs -3.66%
Static Object Property Access (Parser) 11.2±1.08µs 11.9±0.53µs +6.25%
String Object Access (Compiler) 1930.4±110.65ns 1963.6±115.58ns +1.72%
String Object Access (Execution) 9.6±0.58µs 9.4±1.48µs -2.08%
String Object Access (Parser) 14.8±1.35µs 16.4±0.75µs +10.81%
String comparison (Compiler) 2.7±0.16µs 2.7±0.16µs 0.00%
String comparison (Execution) 7.5±0.36µs 7.2±0.52µs -4.00%
String comparison (Parser) 11.6±0.90µs 13.4±0.66µs +15.52%
String concatenation (Compiler) 2.2±0.12µs 2.2±0.11µs 0.00%
String concatenation (Execution) 6.9±0.98µs 6.7±0.39µs -2.90%
String concatenation (Parser) 8.1±0.67µs 9.4±1.57µs +16.05%
String copy (Compiler) 1762.2±93.92ns 1751.2±138.13ns -0.62%
String copy (Execution) 6.2±0.27µs 5.9±0.41µs -4.84%
String copy (Parser) 6.3±0.43µs 6.9±0.28µs +9.52%
Symbols (Compiler) 1286.8±105.54ns 1303.3±61.11ns +1.28%
Symbols (Execution) 5.9±0.18µs 5.8±0.43µs -1.69%
Symbols (Parser) 4.7±0.31µs 5.3±0.29µs +12.77%

@bors
Copy link

bors bot commented Mar 16, 2022

Pull request successfully merged into main.

Build succeeded:

  • Clippy
  • Documentation
  • Examples
  • Rustfmt
  • Tests on Linux
  • Tests on MacOS
  • Tests on Windows

@bors bors bot changed the title Fix link to the playground [Merged by Bors] - Fix link to the playground Mar 16, 2022
@bors bors bot closed this Mar 16, 2022
@HalidOdat HalidOdat deleted the fix-playground-link branch March 16, 2022 17:44
@bors
Copy link

bors bot commented Mar 16, 2022

Already running a review

@Razican Razican added this to the v0.15.0 milestone Jun 1, 2022
Razican pushed a commit that referenced this pull request Jun 8, 2022
Fixes the link to the playground in the Readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation update documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants