Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Implement Promise.allSettled #2146

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Implement Promise.allSettled #2146

wants to merge 1 commit into from

Conversation

raskad
Copy link
Member

@raskad raskad commented Jun 28, 2022

This Pull Request changes the following:

  • Implement Promise.allSettled

@raskad raskad added enhancement New feature or request builtins PRs and Issues related to builtins/intrinsics labels Jun 28, 2022
@raskad raskad added this to the v0.16.0 milestone Jun 28, 2022
@github-actions
Copy link

Test262 conformance changes

VM implementation

Test result main count PR count difference
Total 90,663 90,663 0
Passed 57,516 57,670 +154
Ignored 13,832 13,832 0
Failed 19,315 19,161 -154
Panics 0 0 0
Conformance 63.44% 63.61% +0.17%
Fixed tests (154): 
test/built-ins/Promise/allSettled/capability-executor-not-callable.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/capability-executor-not-callable.js (previously Failed)
test/built-ins/Promise/allSettled/iter-next-val-err-no-close.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/iter-next-val-err-no-close.js (previously Failed)
test/built-ins/Promise/allSettled/iter-assigned-string-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/iter-assigned-string-reject.js (previously Failed)
test/built-ins/Promise/allSettled/invoke-resolve.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/invoke-resolve.js (previously Failed)
test/built-ins/Promise/allSettled/invoke-then-get-error-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/invoke-then-get-error-reject.js (previously Failed)
test/built-ins/Promise/allSettled/name.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/name.js (previously Failed)
test/built-ins/Promise/allSettled/iter-assigned-symbol-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/iter-assigned-symbol-reject.js (previously Failed)
test/built-ins/Promise/allSettled/iter-arg-is-true-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/iter-arg-is-true-reject.js (previously Failed)
test/built-ins/Promise/allSettled/invoke-resolve-on-values-every-iteration-of-promise.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/invoke-resolve-on-values-every-iteration-of-promise.js (previously Failed)
test/built-ins/Promise/allSettled/invoke-resolve-get-once-multiple-calls.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/invoke-resolve-get-once-multiple-calls.js (previously Failed)
test/built-ins/Promise/allSettled/ctx-ctor-throws.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/ctx-ctor-throws.js (previously Failed)
test/built-ins/Promise/allSettled/iter-arg-is-number-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/iter-arg-is-number-reject.js (previously Failed)
test/built-ins/Promise/allSettled/iter-assigned-false-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/iter-assigned-false-reject.js (previously Failed)
test/built-ins/Promise/allSettled/iter-assigned-number-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/iter-assigned-number-reject.js (previously Failed)
test/built-ins/Promise/allSettled/resolves-empty-array.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/resolves-empty-array.js (previously Failed)
test/built-ins/Promise/allSettled/iter-step-err-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/iter-step-err-reject.js (previously Failed)
test/built-ins/Promise/allSettled/resolve-element-function-name.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/resolve-element-function-name.js (previously Failed)
test/built-ins/Promise/allSettled/iter-assigned-true-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/iter-assigned-true-reject.js (previously Failed)
test/built-ins/Promise/allSettled/capability-resolve-throws-no-close.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/capability-resolve-throws-no-close.js (previously Failed)
test/built-ins/Promise/allSettled/iter-returns-string-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/iter-returns-string-reject.js (previously Failed)
test/built-ins/Promise/allSettled/invoke-resolve-get-error-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/invoke-resolve-get-error-reject.js (previously Failed)
test/built-ins/Promise/allSettled/iter-arg-is-string-resolve.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/iter-arg-is-string-resolve.js (previously Failed)
test/built-ins/Promise/allSettled/invoke-resolve-get-once-no-calls.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/invoke-resolve-get-once-no-calls.js (previously Failed)
test/built-ins/Promise/allSettled/resolves-to-array.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/resolves-to-array.js (previously Failed)
test/built-ins/Promise/allSettled/iter-returns-undefined-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/iter-returns-undefined-reject.js (previously Failed)
test/built-ins/Promise/allSettled/reject-element-function-length.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/reject-element-function-length.js (previously Failed)
test/built-ins/Promise/allSettled/reject-element-function-name.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/reject-element-function-name.js (previously Failed)
test/built-ins/Promise/allSettled/invoke-then.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/invoke-then.js (previously Failed)
test/built-ins/Promise/allSettled/resolve-poisoned-then.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/resolve-poisoned-then.js (previously Failed)
test/built-ins/Promise/allSettled/resolve-element-function-prototype.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/resolve-element-function-prototype.js (previously Failed)
test/built-ins/Promise/allSettled/invoke-resolve-on-promises-every-iteration-of-promise.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/invoke-resolve-on-promises-every-iteration-of-promise.js (previously Failed)
test/built-ins/Promise/allSettled/resolve-element-function-nonconstructor.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/resolve-element-function-nonconstructor.js (previously Failed)
test/built-ins/Promise/allSettled/iter-returns-false-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/iter-returns-false-reject.js (previously Failed)
test/built-ins/Promise/allSettled/resolve-thenable.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/resolve-thenable.js (previously Failed)
test/built-ins/Promise/allSettled/iter-step-err-no-close.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/iter-step-err-no-close.js (previously Failed)
test/built-ins/Promise/allSettled/species-get-error.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/species-get-error.js (previously Failed)
test/built-ins/Promise/allSettled/resolved-sequence-extra-ticks.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/resolved-sequence-extra-ticks.js (previously Failed)
test/built-ins/Promise/allSettled/iter-arg-is-poisoned.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/iter-arg-is-poisoned.js (previously Failed)
test/built-ins/Promise/allSettled/does-not-invoke-array-setters.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/does-not-invoke-array-setters.js (previously Failed)
test/built-ins/Promise/allSettled/iter-returns-null-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/iter-returns-null-reject.js (previously Failed)
test/built-ins/Promise/allSettled/iter-arg-is-false-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/iter-arg-is-false-reject.js (previously Failed)
test/built-ins/Promise/allSettled/invoke-resolve-return.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/invoke-resolve-return.js (previously Failed)
test/built-ins/Promise/allSettled/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/prop-desc.js (previously Failed)
test/built-ins/Promise/allSettled/iter-returns-true-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/iter-returns-true-reject.js (previously Failed)
test/built-ins/Promise/allSettled/invoke-then-error-close.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/invoke-then-error-close.js (previously Failed)
test/built-ins/Promise/allSettled/invoke-then-get-error-close.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/invoke-then-get-error-close.js (previously Failed)
test/built-ins/Promise/allSettled/iter-assigned-undefined-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/iter-assigned-undefined-reject.js (previously Failed)
test/built-ins/Promise/allSettled/iter-next-val-err-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/iter-next-val-err-reject.js (previously Failed)
test/built-ins/Promise/allSettled/resolved-immed.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/resolved-immed.js (previously Failed)
test/built-ins/Promise/allSettled/iter-returns-symbol-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/iter-returns-symbol-reject.js (previously Failed)
test/built-ins/Promise/allSettled/resolve-element-function-extensible.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/resolve-element-function-extensible.js (previously Failed)
test/built-ins/Promise/allSettled/invoke-resolve-get-error.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/invoke-resolve-get-error.js (previously Failed)
test/built-ins/Promise/allSettled/resolve-element-function-property-order.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/resolve-element-function-property-order.js (previously Failed)
test/built-ins/Promise/allSettled/resolve-non-callable.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/resolve-non-callable.js (previously Failed)
test/built-ins/Promise/allSettled/resolved-sequence.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/resolved-sequence.js (previously Failed)
test/built-ins/Promise/allSettled/reject-element-function-nonconstructor.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/reject-element-function-nonconstructor.js (previously Failed)
test/built-ins/Promise/allSettled/iter-arg-is-undefined-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/iter-arg-is-undefined-reject.js (previously Failed)
test/built-ins/Promise/allSettled/reject-element-function-multiple-calls.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/reject-element-function-multiple-calls.js (previously Failed)
test/built-ins/Promise/allSettled/capability-executor-called-twice.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/capability-executor-called-twice.js (previously Failed)
test/built-ins/Promise/allSettled/new-resolve-function.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/new-resolve-function.js (previously Failed)
test/built-ins/Promise/allSettled/length.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/length.js (previously Failed)
test/built-ins/Promise/allSettled/capability-resolve-throws-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/capability-resolve-throws-reject.js (previously Failed)
test/built-ins/Promise/allSettled/iter-next-err-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/iter-next-err-reject.js (previously Failed)
test/built-ins/Promise/allSettled/is-function.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/is-function.js (previously Failed)
test/built-ins/Promise/allSettled/new-reject-function.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/new-reject-function.js (previously Failed)
test/built-ins/Promise/allSettled/iter-arg-is-null-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/iter-arg-is-null-reject.js (previously Failed)
test/built-ins/Promise/allSettled/invoke-resolve-error-close.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/invoke-resolve-error-close.js (previously Failed)
test/built-ins/Promise/allSettled/resolve-element-function-length.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/resolve-element-function-length.js (previously Failed)
test/built-ins/Promise/allSettled/invoke-resolve-error-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/invoke-resolve-error-reject.js (previously Failed)
test/built-ins/Promise/allSettled/returns-promise.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/returns-promise.js (previously Failed)
test/built-ins/Promise/allSettled/reject-element-function-prototype.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/reject-element-function-prototype.js (previously Failed)
test/built-ins/Promise/allSettled/iter-arg-is-symbol-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/iter-arg-is-symbol-reject.js (previously Failed)
test/built-ins/Promise/allSettled/reject-element-function-property-order.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/reject-element-function-property-order.js (previously Failed)
test/built-ins/Promise/allSettled/reject-element-function-extensible.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/reject-element-function-extensible.js (previously Failed)
test/built-ins/Promise/allSettled/invoke-then-error-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/invoke-then-error-reject.js (previously Failed)
test/built-ins/Promise/allSettled/iter-assigned-null-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/iter-assigned-null-reject.js (previously Failed)
test/built-ins/Promise/allSettled/iter-returns-number-reject.js [strict mode] (previously Failed)
test/built-ins/Promise/allSettled/iter-returns-number-reject.js (previously Failed)

@codecov
Copy link

codecov bot commented Jun 28, 2022 •
edited

Codecov Report

Merging #2146 (cdc12c1) into main (e81e06b) will decrease coverage by 0.14%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2146      +/-   ##
==========================================
- Coverage   43.28%   43.13%   -0.15%     
==========================================
  Files         220      220              
  Lines       20134    20203      +69     
==========================================
  Hits         8715     8715              
- Misses      11419    11488      +69
Impacted Files Coverage Δ
boa_engine/src/builtins/promise/mod.rs 19.37% <0.00%> (-4.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e81e06b...cdc12c1. Read the comment docs.

Razican
Razican approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loos perfect, thanks!

HalidOdat
HalidOdat approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@HalidOdat
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jun 29, 2022
@raskad
Implement Promise.allSettled (#2146)
c561aa3 
This Pull Request changes the following:

- Implement `Promise.allSettled`
@bors
Copy link

bors bot commented Jun 29, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Implement Promise.allSettled [Merged by Bors] - Implement Promise.allSettled Jun 29, 2022
@bors bors bot closed this Jun 29, 2022
@bors bors bot deleted the promise-all-settled branch June 29, 2022 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Razican Razican Razican approved these changes

@jasonwilliams jasonwilliams jasonwilliams approved these changes

@HalidOdat HalidOdat HalidOdat approved these changes

@RageKnify RageKnify Awaiting requested review from RageKnify

@jedel1043 jedel1043 Awaiting requested review from jedel1043

Assignees
No one assigned
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Projects
None yet
Milestone
v0.16.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@raskad @HalidOdat @Razican @jasonwilliams