[Merged by Bors] - Fix `this` in function calls #2153

raskad · 2022-06-30T18:20:05Z

This Pull Request changes the following:

Fix the this value that is passend to function calls to be undefined if the function is not a property reference
Add special handling for setting the this value for function calls where the function is a private property reference or a super property reference

github-actions · 2022-06-30T18:27:24Z

Test262 conformance changes

VM implementation

Test result	main count	PR count	difference
Total	90,663	90,663	0
Passed	58,166	58,313	+147
Ignored	13,832	13,832	0
Failed	18,665	18,518	-147
Panics	0	0	0
Conformance	64.16%	64.32%	+0.16%

Fixed tests (147):

test/built-ins/Promise/resolve/resolve-from-promise-capability.js [strict mode] (previously Failed)
test/built-ins/Promise/prototype/then/capability-executor-not-callable.js [strict mode] (previously Failed)
test/built-ins/Promise/prototype/then/capability-executor-not-callable.js (previously Failed)
test/built-ins/Promise/prototype/then/deferred-is-resolved-value.js [strict mode] (previously Failed)
test/built-ins/Promise/prototype/then/deferred-is-resolved-value.js (previously Failed)
test/built-ins/Promise/prototype/then/capability-executor-called-twice.js [strict mode] (previously Failed)
test/built-ins/Promise/prototype/then/capability-executor-called-twice.js (previously Failed)
test/built-ins/Promise/reject/capability-invocation.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/called-as-function.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/called-as-function.js (previously Failed)
test/built-ins/Error/prototype/toString/called-as-function.js [strict mode] (previously Failed)
test/built-ins/Error/prototype/toString/called-as-function.js (previously Failed)
test/built-ins/Object/prototype/valueOf/S15.2.4.4_A15.js [strict mode] (previously Failed)
test/built-ins/Object/prototype/valueOf/S15.2.4.4_A15.js (previously Failed)
test/built-ins/Object/prototype/valueOf/S15.2.4.4_A14.js [strict mode] (previously Failed)
test/built-ins/Object/prototype/valueOf/S15.2.4.4_A14.js (previously Failed)
test/built-ins/TypedArrayConstructors/from/invoked-as-func.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/from/invoked-as-func.js (previously Failed)
test/built-ins/TypedArrayConstructors/from/BigInt/invoked-as-func.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/from/BigInt/invoked-as-func.js (previously Failed)
test/built-ins/TypedArray/from/invoked-as-func.js [strict mode] (previously Failed)
test/built-ins/TypedArray/from/invoked-as-func.js (previously Failed)
test/built-ins/TypedArray/prototype/reduce/callbackfn-this.js [strict mode] (previously Failed)
test/built-ins/TypedArray/prototype/reduce/BigInt/callbackfn-this.js [strict mode] (previously Failed)
test/built-ins/TypedArray/prototype/forEach/callbackfn-this.js [strict mode] (previously Failed)
test/built-ins/TypedArray/prototype/forEach/BigInt/callbackfn-this.js [strict mode] (previously Failed)
test/built-ins/TypedArray/prototype/every/callbackfn-this.js [strict mode] (previously Failed)
test/built-ins/TypedArray/prototype/every/BigInt/callbackfn-this.js [strict mode] (previously Failed)
test/built-ins/TypedArray/prototype/reduceRight/callbackfn-this.js [strict mode] (previously Failed)
test/built-ins/TypedArray/prototype/reduceRight/BigInt/callbackfn-this.js [strict mode] (previously Failed)
test/built-ins/TypedArray/prototype/map/callbackfn-this.js [strict mode] (previously Failed)
test/built-ins/TypedArray/prototype/map/BigInt/callbackfn-this.js [strict mode] (previously Failed)
test/built-ins/TypedArray/prototype/filter/callbackfn-this.js [strict mode] (previously Failed)
test/built-ins/TypedArray/prototype/filter/BigInt/callbackfn-this.js [strict mode] (previously Failed)
test/built-ins/TypedArray/prototype/toLocaleString/invoked-as-func.js [strict mode] (previously Failed)
test/built-ins/TypedArray/prototype/toLocaleString/invoked-as-func.js (previously Failed)
test/built-ins/TypedArray/prototype/sort/comparefn-calls.js [strict mode] (previously Failed)
test/built-ins/TypedArray/prototype/sort/BigInt/comparefn-calls.js [strict mode] (previously Failed)
test/built-ins/TypedArray/prototype/some/callbackfn-this.js [strict mode] (previously Failed)
test/built-ins/TypedArray/prototype/some/BigInt/callbackfn-this.js [strict mode] (previously Failed)
test/built-ins/String/prototype/replaceAll/replaceValue-call-each-match-position.js [strict mode] (previously Failed)
test/built-ins/String/prototype/replaceAll/replaceValue-call-matching-empty.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/methods-called-as-functions.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/methods-called-as-functions.js (previously Failed)
test/language/statements/class/definition/this-access-restriction.js [strict mode] (previously Failed)
test/language/statements/class/definition/this-access-restriction.js (previously Failed)
test/language/function-code/10.4.3-1-45gs.js (previously Failed)
test/language/function-code/10.4.3-1-27-s.js [strict mode] (previously Failed)
test/language/function-code/10.4.3-1-48-s.js (previously Failed)
test/language/function-code/10.4.3-1-63-s.js [strict mode] (previously Failed)
test/language/function-code/10.4.3-1-63-s.js (previously Failed)
test/language/function-code/10.4.3-1-35gs.js [strict mode] (previously Failed)
test/language/function-code/10.4.3-1-30gs.js [strict mode] (previously Failed)
test/language/function-code/10.4.3-1-47gs.js (previously Failed)
test/language/function-code/10.4.3-1-9-s.js [strict mode] (previously Failed)
test/language/function-code/10.4.3-1-65-s.js [strict mode] (previously Failed)
test/language/function-code/10.4.3-1-65-s.js (previously Failed)
test/language/function-code/10.4.3-1-16gs.js (previously Failed)
test/language/function-code/10.4.3-1-10gs.js (previously Failed)
test/language/function-code/10.4.3-1-29gs.js [strict mode] (previously Failed)
test/language/function-code/10.4.3-1-31-s.js [strict mode] (previously Failed)
test/language/function-code/10.4.3-1-43-s.js (previously Failed)
test/language/function-code/10.4.3-1-44gs.js (previously Failed)
test/language/function-code/10.4.3-1-41-s.js (previously Failed)
test/language/function-code/10.4.3-1-17-s.js [strict mode] (previously Failed)
test/language/function-code/10.4.3-1-49gs.js (previously Failed)
test/language/function-code/10.4.3-1-8gs.js (previously Failed)
test/language/function-code/10.4.3-1-28gs.js [strict mode] (previously Failed)
test/language/function-code/10.4.3-1-11gs.js [strict mode] (previously Failed)
test/language/function-code/10.4.3-1-7-s.js [strict mode] (previously Failed)
test/language/function-code/10.4.3-1-11-s.js [strict mode] (previously Failed)
test/language/function-code/10.4.3-1-43gs.js (previously Failed)
test/language/function-code/S10.4.3_A1.js [strict mode] (previously Failed)
test/language/function-code/10.4.3-1-44-s.js (previously Failed)
test/language/function-code/10.4.3-1-42gs.js (previously Failed)
test/language/function-code/10.4.3-1-16-s.js (previously Failed)
test/language/function-code/10.4.3-1-51-s.js (previously Failed)
test/language/function-code/10.4.3-1-34gs.js [strict mode] (previously Failed)
test/language/function-code/10.4.3-1-48gs.js (previously Failed)
test/language/function-code/10.4.3-1-46-s.js (previously Failed)
test/language/function-code/10.4.3-1-65gs.js [strict mode] (previously Failed)
test/language/function-code/10.4.3-1-65gs.js (previously Failed)
test/language/function-code/10.4.3-1-30-s.js [strict mode] (previously Failed)
test/language/function-code/10.4.3-1-12-s.js (previously Failed)
test/language/function-code/10.4.3-1-9gs.js [strict mode] (previously Failed)
test/language/function-code/10.4.3-1-50-s.js (previously Failed)
test/language/function-code/10.4.3-1-38-s.js (previously Failed)
test/language/function-code/10.4.3-1-51gs.js (previously Failed)
test/language/function-code/10.4.3-1-52gs.js (previously Failed)
test/language/function-code/10.4.3-1-53gs.js (previously Failed)
test/language/function-code/10.4.3-1-64-s.js [strict mode] (previously Failed)
test/language/function-code/10.4.3-1-64-s.js (previously Failed)
test/language/function-code/10.4.3-1-46gs.js (previously Failed)
test/language/function-code/10.4.3-1-62gs.js [strict mode] (previously Failed)
test/language/function-code/10.4.3-1-62gs.js (previously Failed)
test/language/function-code/10.4.3-1-33gs.js [strict mode] (previously Failed)
test/language/function-code/10.4.3-1-49-s.js (previously Failed)
test/language/function-code/10.4.3-1-12gs.js (previously Failed)
test/language/function-code/10.4.3-1-50gs.js (previously Failed)
test/language/function-code/10.4.3-1-28-s.js [strict mode] (previously Failed)
test/language/function-code/10.4.3-1-27gs.js [strict mode] (previously Failed)
test/language/function-code/10.4.3-1-39-s.js (previously Failed)
test/language/function-code/10.4.3-1-45-s.js (previously Failed)
test/language/function-code/10.4.3-1-62-s.js [strict mode] (previously Failed)
test/language/function-code/10.4.3-1-62-s.js (previously Failed)
test/language/function-code/10.4.3-1-10-s.js (previously Failed)
test/language/function-code/10.4.3-1-40gs.js (previously Failed)
test/language/function-code/10.4.3-1-37-s.js (previously Failed)
test/language/function-code/10.4.3-1-32-s.js [strict mode] (previously Failed)
test/language/function-code/10.4.3-1-14-s.js (previously Failed)
test/language/function-code/10.4.3-1-14gs.js (previously Failed)
test/language/function-code/10.4.3-1-32gs.js [strict mode] (previously Failed)
test/language/function-code/10.4.3-1-34-s.js [strict mode] (previously Failed)
test/language/function-code/10.4.3-1-42-s.js (previously Failed)
test/language/function-code/10.4.3-1-36-s.js (previously Failed)
test/language/function-code/10.4.3-1-29-s.js [strict mode] (previously Failed)
test/language/function-code/10.4.3-1-8-s.js (previously Failed)
test/language/function-code/10.4.3-1-64gs.js [strict mode] (previously Failed)
test/language/function-code/10.4.3-1-64gs.js (previously Failed)
test/language/function-code/10.4.3-1-36gs.js (previously Failed)
test/language/function-code/10.4.3-1-37gs.js (previously Failed)
test/language/function-code/10.4.3-1-40-s.js (previously Failed)
test/language/function-code/10.4.3-1-63gs.js [strict mode] (previously Failed)
test/language/function-code/10.4.3-1-63gs.js (previously Failed)
test/language/function-code/10.4.3-1-41gs.js (previously Failed)
test/language/function-code/10.4.3-1-38gs.js (previously Failed)
test/language/function-code/10.4.3-1-7gs.js [strict mode] (previously Failed)
test/language/function-code/10.4.3-1-35-s.js [strict mode] (previously Failed)
test/language/function-code/10.4.3-1-52-s.js (previously Failed)
test/language/function-code/10.4.3-1-31gs.js [strict mode] (previously Failed)
test/language/function-code/10.4.3-1-33-s.js [strict mode] (previously Failed)
test/language/function-code/10.4.3-1-47-s.js (previously Failed)
test/language/function-code/10.4.3-1-53-s.js (previously Failed)
test/language/function-code/10.4.3-1-39gs.js (previously Failed)
test/language/eval-code/direct/this-value-func-strict-caller.js [strict mode] (previously Failed)
test/language/expressions/super/call-spread-err-mult-err-expr-throws.js [strict mode] (previously Failed)
test/language/expressions/super/call-spread-err-mult-err-expr-throws.js (previously Failed)
test/language/expressions/super/call-arg-evaluation-err.js [strict mode] (previously Failed)
test/language/expressions/super/call-arg-evaluation-err.js (previously Failed)
test/language/expressions/super/call-spread-err-sngl-err-expr-throws.js [strict mode] (previously Failed)
test/language/expressions/super/call-spread-err-sngl-err-expr-throws.js (previously Failed)
test/language/expressions/super/call-spread-obj-with-overrides.js [strict mode] (previously Failed)
test/language/expressions/super/call-spread-obj-with-overrides.js (previously Failed)
test/language/expressions/object/method-definition/generator-invoke-fn-strict.js (previously Failed)
test/language/expressions/object/method-definition/name-invoke-fn-strict.js (previously Failed)
test/language/expressions/arrow-function/lexical-supercall-from-immediately-invoked-arrow.js [strict mode] (previously Failed)
test/language/expressions/arrow-function/lexical-supercall-from-immediately-invoked-arrow.js (previously Failed)

codecov · 2022-06-30T18:32:57Z

Codecov Report

Merging #2153 (4516249) into main (6b4ebf9) will decrease coverage by 0.03%.
The diff coverage is 8.69%.

@@            Coverage Diff             @@
##             main    #2153      +/-   ##
==========================================
- Coverage   42.73%   42.70%   -0.04%     
==========================================
  Files         225      225              
  Lines       20780    20790      +10     
==========================================
- Hits         8880     8878       -2     
- Misses      11900    11912      +12

Impacted Files	Coverage Δ
boa_engine/src/bytecompiler.rs	`30.99% <0.00%> (-0.29%)`	⬇️
boa_engine/src/vm/mod.rs	`49.14% <50.00%> (+0.18%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b4ebf9...4516249. Read the comment docs.

raskad · 2022-07-01T10:41:11Z

bors r+

bors · 2022-07-01T10:41:13Z

Did you mean "r+"?

raskad · 2022-07-01T10:42:03Z

bors r+

This Pull Request changes the following: - Fix the `this` value that is passend to function calls to be `undefined` if the function is not a property reference - Add special handling for setting the `this` value for function calls where the function is a private property reference or a super property reference

bors · 2022-07-01T10:59:12Z

Pull request successfully merged into main.

Build succeeded:

raskad added bug Something isn't working execution Issues or PRs related to code execution labels Jun 30, 2022

raskad added this to the v0.16.0 milestone Jun 30, 2022

raskad requested review from Razican, jasonwilliams, HalidOdat, RageKnify and jedel1043 June 30, 2022 18:20

jasonwilliams approved these changes Jun 30, 2022

View reviewed changes

Fix this in function calls

4516249

raskad force-pushed the fix-call-this branch from 58ee15d to 4516249 Compare June 30, 2022 21:47

HalidOdat approved these changes Jul 1, 2022

View reviewed changes

bors bot changed the title ~~Fix this in function calls~~ [Merged by Bors] - Fix this in function calls Jul 1, 2022

bors bot closed this Jul 1, 2022

bors bot deleted the fix-call-this branch July 1, 2022 10:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Merged by Bors] - Fix `this` in function calls #2153

[Merged by Bors] - Fix `this` in function calls #2153

raskad commented Jun 30, 2022

github-actions bot commented Jun 30, 2022

codecov bot commented Jun 30, 2022 •

edited

raskad commented Jul 1, 2022 •

edited

bors bot commented Jul 1, 2022

raskad commented Jul 1, 2022

bors bot commented Jul 1, 2022

[Merged by Bors] - Fix this in function calls #2153

[Merged by Bors] - Fix this in function calls #2153

Conversation

raskad commented Jun 30, 2022

github-actions bot commented Jun 30, 2022

Test262 conformance changes

VM implementation

codecov bot commented Jun 30, 2022 • edited

Codecov Report

raskad commented Jul 1, 2022 • edited

bors bot commented Jul 1, 2022

raskad commented Jul 1, 2022

bors bot commented Jul 1, 2022

[Merged by Bors] - Fix `this` in function calls #2153

[Merged by Bors] - Fix `this` in function calls #2153

codecov bot commented Jun 30, 2022 •

edited

raskad commented Jul 1, 2022 •

edited