Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix Rust 1.63 clippy lints #2230

Closed
wants to merge 1 commit into from
Closed

Conversation

raskad
Copy link
Member

@raskad raskad commented Aug 11, 2022

This Pull Request changes the following:

  • Fix Rust 1.63 clippy lints

@raskad raskad added rust Pull requests that update Rust code Internal Category for changelog labels Aug 11, 2022
@raskad raskad added this to the v0.16.0 milestone Aug 11, 2022
@github-actions
Copy link

Test262 conformance changes

VM implementation

Test result main count PR count difference
Total 91,573 91,573 0
Passed 59,820 59,820 0
Ignored 14,606 14,606 0
Failed 17,147 17,147 0
Panics 0 0 0
Conformance 65.32% 65.32% 0.00%

@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #2230 (a05b1f2) into main (e9e44d2) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2230      +/-   ##
==========================================
+ Coverage   41.96%   41.99%   +0.03%     
==========================================
  Files         231      231              
  Lines       21516    21530      +14     
==========================================
+ Hits         9029     9042      +13     
- Misses      12487    12488       +1     
Impacted Files Coverage Δ
boa_engine/src/builtins/function/mod.rs 25.26% <ø> (-0.40%) ⬇️
boa_engine/src/builtins/intl/mod.rs 60.95% <ø> (ø)
boa_engine/src/builtins/map/mod.rs 83.87% <ø> (ø)
boa_engine/src/syntax/ast/keyword.rs 95.91% <ø> (ø)
boa_engine/src/syntax/ast/node/identifier/mod.rs 18.18% <ø> (ø)
...ne/src/syntax/ast/node/iteration/break_node/mod.rs 50.00% <ø> (ø)
...src/syntax/ast/node/iteration/continue_node/mod.rs 50.00% <ø> (ø)
boa_engine/src/syntax/ast/node/mod.rs 61.75% <ø> (ø)
boa_engine/src/syntax/ast/op.rs 58.82% <ø> (ø)
boa_engine/src/syntax/ast/punctuator.rs 12.50% <ø> (ø)
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

@HalidOdat
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Aug 12, 2022
This Pull Request changes the following:

- Fix Rust 1.63 clippy lints
@bors
Copy link

bors bot commented Aug 12, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix Rust 1.63 clippy lints [Merged by Bors] - Fix Rust 1.63 clippy lints Aug 12, 2022
@bors bors bot closed this Aug 12, 2022
@bors bors bot deleted the rust-1.63-fixes branch August 12, 2022 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Category for changelog rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants