[Merged by Bors] - Do not auto-insert semicolon in VariableDeclarationList #2266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2266 +/- ##
==========================================
- Coverage 41.30% 41.30% -0.01%
==========================================
Files 234 234
Lines 22018 22015 -3
==========================================
- Hits 9095 9093 -2
+ Misses 12923 12922 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Test262 conformance changesVM implementation
Fixed tests (4): |
Razican
approved these changes
Sep 5, 2022
Razican
requested review from
HalidOdat,
jasonwilliams,
jedel1043,
RageKnify and
raskad
raskad
approved these changes
Sep 5, 2022
|
bors r+ |
|
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Sep 5, 2022
There can be a line terminator in the middle of variable declaration statement. For example, ```js var a , b; ``` In this case, we should not insert semicolon automatically. This fixes: - test262/test/language/asi/S7.9_A7_T8.js - test262/test/language/asi/S7.9_A7_T9.js
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There can be a line terminator in the middle of variable declaration statement. For example,
In this case, we should not insert semicolon automatically.
This fixes: