Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix some Array spec deviations #2306

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Fix some Array spec deviations #2306

wants to merge 1 commit into from

Conversation

raskad
Copy link
Member

@raskad raskad commented Sep 25, 2022

This Pull Request changes the following:

  • Fix array constructor realm comparison.
  • Fix error that ignored ToObject.
  • Ignore array-grouping feature tests.

@raskad raskad added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Sep 25, 2022
@raskad raskad added this to the v0.17.0 milestone Sep 25, 2022
@github-actions
Copy link

Test262 conformance changes

VM implementation

Test result main count PR count difference
Total 92,057 92,057 0
Passed 68,704 68,712 +8
Ignored 16,832 16,904 +72
Failed 6,521 6,441 -80
Panics 0 0 0
Conformance 74.63% 74.64% +0.01%
Fixed tests (16): 
test/built-ins/Array/prototype/splice/create-proto-from-ctor-realm-array.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/splice/create-proto-from-ctor-realm-array.js (previously Failed)
test/built-ins/Array/prototype/filter/create-proto-from-ctor-realm-array.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/filter/create-proto-from-ctor-realm-array.js (previously Failed)
test/built-ins/Array/prototype/map/create-proto-from-ctor-realm-array.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/map/create-proto-from-ctor-realm-array.js (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-1-5.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-1-5.js (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-1-7.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-1-7.js (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-1-3.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-1-3.js (previously Failed)
test/built-ins/Array/prototype/concat/create-proto-from-ctor-realm-array.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/concat/create-proto-from-ctor-realm-array.js (previously Failed)
test/built-ins/Array/prototype/slice/create-proto-from-ctor-realm-array.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/slice/create-proto-from-ctor-realm-array.js (previously Failed)

jedel1043
jedel1043 requested changes Sep 25, 2022
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nitpick

boa_engine/src/builtins/array/mod.rs Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 25, 2022

Codecov Report

Merging #2306 (0e6bb74) into main (e9e85f5) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2306      +/-   ##
==========================================
- Coverage   41.19%   41.16%   -0.04%     
==========================================
  Files         237      237              
  Lines       22375    22378       +3     
==========================================
- Hits         9218     9212       -6     
- Misses      13157    13166       +9
Impacted Files Coverage Δ
boa_engine/src/builtins/array/mod.rs 73.60% <100.00%> (-1.32%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

jedel1043
jedel1043 approved these changes Sep 25, 2022
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

Razican
Razican approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Razican
Copy link
Member

Razican commented Sep 26, 2022

Bors r+

bors bot pushed a commit that referenced this pull request Sep 26, 2022
@raskad
Fix some Array spec deviations (#2306)
9f0ac30 
This Pull Request changes the following:

- Fix array constructor realm comparison.
- Fix error that ignored `ToObject`.
- Ignore `array-grouping` feature tests.
@bors
Copy link

bors bot commented Sep 26, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix some Array spec deviations [Merged by Bors] - Fix some Array spec deviations Sep 26, 2022
@bors bors bot closed this Sep 26, 2022
@bors bors bot deleted the fix-array-spec branch September 26, 2022 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Razican Razican Razican approved these changes

@jedel1043 jedel1043 jedel1043 approved these changes

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

@HalidOdat HalidOdat Awaiting requested review from HalidOdat

@RageKnify RageKnify Awaiting requested review from RageKnify

Assignees
No one assigned
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@raskad @Razican @jedel1043