[Merged by Bors] - Split vm/opcode into modules #2343
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2343 +/- ##
==========================================
+ Coverage 39.84% 40.09% +0.24%
==========================================
Files 242 304 +62
Lines 23242 23369 +127
==========================================
+ Hits 9260 9369 +109
- Misses 13982 14000 +18
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Razican
added
enhancement
|
Great work!! Thank you for this contribution :) This is related to #1808, but for the VM instead of the byte compiler, if I'm not mistaken. |
nekevss
force-pushed
the
implement-opcode-modules
branch
from
fcc0fa9
to
d1e678a
Compare
nekevss
force-pushed
the
implement-opcode-modules
branch
from
d1e678a
to
a1647d8
Compare
|
Just wanted to follow up that this is probably ready for review (updated to some of the recent pull requests). 😄 |
Razican
requested review from
Razican,
HalidOdat,
jasonwilliams,
jedel1043,
RageKnify and
raskad
Test262 conformance changesVM implementation
|
Razican
reviewed
Oct 21, 2022
There was a problem hiding this comment.
Great work!! This is very helpful.
I added a couple of comments. I like the approach, and I would be OK to merge it as-is, but check if my comments make sense. Also, this is missing documentation of all the op-codes, but we didn't have such documentation before, so, if you add it, that would be great, but if not, I'm OK to merge it as-is and create an issue to do it later :)
|
I like the change. I pushed an empty commit to trigger the benchmarks to see if there is any noticeable change in how the code is compiled/optimized. |
RageKnify
approved these changes
Oct 22, 2022
|
Too much standard deviation, difficult to say, but I don't see it went worse, and we might even have some gains. |
raskad
approved these changes
Oct 22, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 22, 2022
<!--- Thank you for contributing to Boa! Please fill out the template below, and remove or add any information as you feel necessary. ---> Hi! This isn't really related to a pull request that I know of. I was trying to better wrap my head around Boa's VM and thought I'd break it apart so that the file wasn't 2500+ lines. I figured I'd submit it as a draft and get feedback/see if anyone was interested in it. The way the modules were broken apart was primarily based off the opcode name (`GetFunction` & `GetFunctionAsync` -> `./get/function.rs`). It changes the following: - Adds an `Operation` trait to opcode/mod.rs - Implements `Operation` for each Opcode variant, moving the executable instruction code from `vm/mod.rs` to the respective module Co-authored-by: raskad <32105367+raskad@users.noreply.github.com>
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This isn't really related to a pull request that I know of. I was trying to better wrap my head around Boa's VM and thought I'd break it apart so that the file wasn't 2500+ lines. I figured I'd submit it as a draft and get feedback/see if anyone was interested in it. The way the modules were broken apart was primarily based off the opcode name (
GetFunction&GetFunctionAsync->./get/function.rs).It changes the following:
Operationtrait to opcode/mod.rsOperationfor each Opcode variant, moving the executable instruction code fromvm/mod.rsto the respective module