Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fixed some documentation and clippy warnings in tests #2362

Closed
wants to merge 1 commit into from

Conversation

Razican
Copy link
Member

@Razican Razican commented Oct 21, 2022

This Pull Request fixes a small error in the documentation of Context::register_global_function() method, and a few clippy errors we were getting in the tests.

@Razican Razican added enhancement New feature or request documentation update documentation test Issues and PRs related to the tests. labels Oct 21, 2022
@Razican Razican added this to the v0.17.0 milestone Oct 21, 2022
@github-actions
Copy link

Test262 conformance changes

VM implementation

Test result main count PR count difference
Total 93,383 93,383 0
Passed 69,095 69,095 0
Ignored 18,182 18,182 0
Failed 6,106 6,106 0
Panics 0 0 0
Conformance 73.99% 73.99% 0.00%

@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Merging #2362 (38f5281) into main (d51fee7) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2362      +/-   ##
==========================================
- Coverage   39.84%   39.83%   -0.01%     
==========================================
  Files         242      242              
  Lines       23242    23243       +1     
==========================================
  Hits         9260     9260              
- Misses      13982    13983       +1     
Impacted Files Coverage Δ
boa_engine/src/context/mod.rs 34.75% <ø> (ø)
...ntax/parser/expression/left_hand_side/arguments.rs 35.00% <0.00%> (-2.50%) ⬇️
boa_engine/src/value/mod.rs 52.39% <0.00%> (+0.16%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jedel1043
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Oct 21, 2022
This Pull Request fixes a small error in the documentation of `Context::register_global_function()` method, and a few clippy errors we were getting in the tests.
@bors
Copy link

bors bot commented Oct 21, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fixed some documentation and clippy warnings in tests [Merged by Bors] - Fixed some documentation and clippy warnings in tests Oct 21, 2022
@bors bors bot closed this Oct 21, 2022
@bors bors bot deleted the fix_docs branch October 21, 2022 16:02
@Razican Razican added the hacktoberfest-accepted PR accepted for Hacktoberfest label Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation update documentation enhancement New feature or request hacktoberfest-accepted PR accepted for Hacktoberfest test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants