Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Set in to true when parsing AssignmentExpression in ConditionalExpression #2386

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Set in to true when parsing AssignmentExpression in ConditionalExpression #2386

wants to merge 1 commit into from

Conversation

raskad
Copy link
Member

@raskad raskad commented Oct 26, 2022

This Pull Request fixes the following:

  • Set in to true when parsing AssignmentExpression in ConditionalExpression

@raskad raskad added bug Something isn't working parser Issues surrounding the parser labels Oct 26, 2022
@raskad raskad added this to the v0.17.0 milestone Oct 26, 2022
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 93,789 93,789 0
Passed 69,179 69,181 +2
Ignored 18,352 18,352 0
Failed 6,258 6,256 -2
Panics 0 0 0
Conformance 73.76% 73.76% +0.00%
Fixed tests (2): 
test/language/expressions/conditional/in-branch-1.js [strict mode] (previously Failed)
test/language/expressions/conditional/in-branch-1.js (previously Failed)

@codecov
Copy link

codecov bot commented Oct 26, 2022 •
edited

Codecov Report

Merging #2386 (8994c26) into main (762dd93) will decrease coverage by 0.02%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main    #2386      +/-   ##
==========================================
- Coverage   40.02%   40.00%   -0.03%     
==========================================
  Files         304      305       +1     
  Lines       23306    23325      +19     
==========================================
+ Hits         9328     9330       +2     
- Misses      13978    13995      +17
Impacted Files Coverage Δ
...syntax/parser/expression/assignment/conditional.rs 53.84% <33.33%> (+7.41%) ⬆️
boa_engine/src/error.rs 58.82% <0.00%> (-1.18%) ⬇️
boa_engine/src/object/mod.rs 19.54% <0.00%> (-0.13%) ⬇️
boa_engine/src/object/builtins/jsset.rs 0.00% <0.00%> (ø)
boa_engine/src/object/builtins/jsarray.rs 5.05% <0.00%> (ø)
boa_engine/src/object/builtins/jsproxy.rs 0.00% <0.00%> (ø)
boa_engine/src/object/builtins/jsfunction.rs 40.00% <0.00%> (ø)
boa_engine/src/object/builtins/jstypedarray.rs 0.00% <0.00%> (ø)
boa_engine/src/object/builtins/jsarraybuffer.rs 0.00% <0.00%> (ø)
boa_engine/src/object/builtins/jsset_iterator.rs 0.00% <0.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Razican
Razican approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Good catch :)

jedel1043
jedel1043 approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jedel1043
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Oct 26, 2022
@raskad
Set in to true when parsing AssignmentExpression in ConditionalEx…
7863579 
…pression (#2386)

This Pull Request fixes the following:

- Set `in` to `true` when parsing AssignmentExpression in ConditionalExpression
@bors
Copy link

bors bot commented Oct 26, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Set in to true when parsing AssignmentExpression in ConditionalExpression [Merged by Bors] - Set in to true when parsing AssignmentExpression in ConditionalExpression Oct 26, 2022
@bors bors bot closed this Oct 26, 2022
@bors bors bot deleted the fix-cond-expr-in branch October 26, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Razican Razican Razican approved these changes

@jedel1043 jedel1043 jedel1043 approved these changes

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

@HalidOdat HalidOdat Awaiting requested review from HalidOdat

@RageKnify RageKnify Awaiting requested review from RageKnify

Assignees
No one assigned
Labels
bug Something isn't working parser Issues surrounding the parser
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@raskad @jedel1043 @Razican