Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix async tests result values #2406

Closed
wants to merge 3 commits into from
Closed

Conversation

jedel1043
Copy link
Member

@jedel1043 jedel1043 commented Nov 5, 2022

So, there were some tests that weren't reporting the result of async evaluations correctly. This PR fixes this. It also ignores tests with the IsHTMLDDA feature, since we haven't implemented it.

On another note, this also changes the symbols of the test suite to 'F' (failed) and '-' (ignored), which is clearer for colorless terminals.

@jedel1043 jedel1043 added the Internal Category for changelog label Nov 5, 2022
@jedel1043 jedel1043 added this to the v0.17.0 milestone Nov 5, 2022
@github-actions
Copy link

github-actions bot commented Nov 5, 2022

Test262 conformance changes

Test result main count PR count difference
Total 93,789 93,789 0
Passed 69,513 69,482 -31
Ignored 18,352 18,422 +70
Failed 5,924 5,885 -39
Panics 0 0 0
Conformance 74.12% 74.08% -0.03%
Broken tests (11):
test/language/statements/for-await-of/async-func-decl-dstr-array-elem-put-unresolvable-strict.js [strict mode] (previously Passed)
test/language/statements/for-await-of/async-gen-decl-dstr-array-elem-put-unresolvable-strict.js [strict mode] (previously Passed)
test/language/statements/for-await-of/async-gen-decl-dstr-array-elem-put-const.js [strict mode] (previously Passed)
test/language/statements/for-await-of/async-gen-decl-dstr-array-elem-put-const.js (previously Passed)
test/language/statements/for-await-of/async-func-decl-dstr-obj-prop-elem-target-yield-ident-valid.js (previously Passed)
test/language/statements/for-await-of/async-func-decl-dstr-array-elem-put-const.js [strict mode] (previously Passed)
test/language/statements/for-await-of/async-func-decl-dstr-array-elem-put-const.js (previously Passed)
test/language/statements/for-await-of/async-gen-decl-dstr-array-elem-iter-rtrn-close-null.js [strict mode] (previously Passed)
test/language/statements/for-await-of/async-gen-decl-dstr-array-elem-iter-rtrn-close-null.js (previously Passed)
test/language/expressions/async-generator/expression-yield-as-operand.js [strict mode] (previously Passed)
test/language/expressions/async-generator/expression-yield-as-operand.js (previously Passed)

@codecov
Copy link

codecov bot commented Nov 5, 2022

Codecov Report

Merging #2406 (19980cd) into main (91235c7) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2406      +/-   ##
==========================================
- Coverage   38.85%   38.85%   -0.01%     
==========================================
  Files         313      313              
  Lines       23846    23846              
==========================================
- Hits         9266     9265       -1     
- Misses      14580    14581       +1     
Impacted Files Coverage Δ
boa_ast/src/property.rs 18.96% <0.00%> (-1.73%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@raskad
Copy link
Member

raskad commented Nov 5, 2022

bors r+

bors bot pushed a commit that referenced this pull request Nov 5, 2022
So, there were some tests that weren't reporting the result of async evaluations correctly. This PR fixes this. It also ignores tests with the `IsHTMLDDA` feature, since we haven't implemented it.

On another note, this also changes the symbols of the test suite to 'F' (failed) and '-' (ignored), which is clearer for colorless terminals.
@bors
Copy link

bors bot commented Nov 5, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix async tests result values [Merged by Bors] - Fix async tests result values Nov 5, 2022
@bors bors bot closed this Nov 5, 2022
@bors bors bot deleted the test-flags branch November 5, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Category for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants