[Merged by Bors] - Fix PartialEq for JsBigInt and f64
#2461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raskad
requested review from
Razican,
jasonwilliams,
HalidOdat,
RageKnify and
jedel1043
Test262 conformance changes
Fixed tests (4): |
Codecov Report
@@ Coverage Diff @@
## main #2461 +/- ##
==========================================
- Coverage 51.51% 51.07% -0.45%
==========================================
Files 339 344 +5
Lines 35515 35825 +310
==========================================
- Hits 18297 18296 -1
- Misses 17218 17529 +311
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Razican
requested changes
Nov 25, 2022
boa_engine/src/bigint.rs
Outdated
| @@ -453,21 +453,21 @@ impl PartialEq<JsBigInt> for i32 { | |||
| impl PartialEq<f64> for JsBigInt { | |||
| #[inline] | |||
| fn eq(&self, other: &f64) -> bool { | |||
| if other.fract() != 0.0 { | |||
| return false; | |||
| if other.fract().is_zero() { | |||
There was a problem hiding this comment.
This could just be an && operation, right? Instead of an if/else
boa_engine/src/bigint.rs
Outdated
| } | ||
| } | ||
|
|
||
| impl PartialEq<JsBigInt> for f64 { | ||
| #[inline] | ||
| fn eq(&self, other: &JsBigInt) -> bool { | ||
| if self.fract() != 0.0 { | ||
| return false; | ||
| if self.fract().is_zero() { |
There was a problem hiding this comment.
Same here, it could just be an && operation.
HalidOdat
approved these changes
Nov 25, 2022
|
bors r+ |
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
PartialEq for JsBigInt and f64PartialEq for JsBigInt and f64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request changes the following:
BigInt::from_f64function when checkingJsBigIntandf64for eqality.