Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix to weak_trace for boa_tester #2470

Closed
wants to merge 1 commit into from

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Dec 2, 2022

This Pull Request fixes the current issue with the boa_gc when running boa_tester in parallel on Ubuntu. It looks like since we are running the gc in parallel something may not being cleaned up correctly that creates a reference cycle. The below changes should account for that.

It changes the following:

  • Updates weak_trace to account for Gc reference cycles.

@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Merging #2470 (f4442f7) into main (920a86f) will increase coverage by 0.33%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##             main    #2470      +/-   ##
==========================================
+ Coverage   51.07%   51.40%   +0.33%     
==========================================
  Files         345      335      -10     
  Lines       35942    35626     -316     
==========================================
- Hits        18357    18315      -42     
+ Misses      17585    17311     -274     
Impacted Files Coverage Δ
boa_gc/src/internals/gc_box.rs 78.68% <20.00%> (-6.06%) ⬇️
boa_gc/src/pointers/ephemeron.rs 47.36% <0.00%> (-44.74%) ⬇️
boa_gc/src/pointers/weak.rs 44.44% <0.00%> (-44.45%) ⬇️
boa_gc/src/internals/ephemeron_box.rs 48.71% <0.00%> (-38.47%) ⬇️
boa_interner/src/lib.rs 80.67% <0.00%> (-3.37%) ⬇️
boa_gc/src/trace.rs 78.43% <0.00%> (-1.97%) ⬇️
boa_gc/src/lib.rs 98.42% <0.00%> (-1.58%) ⬇️
boa_examples/src/bin/jsset.rs
boa_examples/src/bin/modulehandler.rs
boa_examples/src/bin/loadfile.rs
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nekevss nekevss added the bug Something isn't working label Dec 2, 2022
@jedel1043 jedel1043 added this to the v0.17.0 milestone Dec 2, 2022
@raskad
Copy link
Member

raskad commented Dec 2, 2022

bors r+

bors bot pushed a commit that referenced this pull request Dec 2, 2022
<!---
Thank you for contributing to Boa! Please fill out the template below, and remove or add any
information as you feel necessary.
--->

This Pull Request fixes the current issue with the `boa_gc` when running `boa_tester` in parallel on Ubuntu. It looks like since we are running the `gc` in parallel something may not being cleaned up correctly that creates a reference cycle. The below changes should account for that.

It changes the following:

- Updates `weak_trace` to account for `Gc` reference cycles.
@bors
Copy link

bors bot commented Dec 2, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix to weak_trace for boa_tester [Merged by Bors] - Fix to weak_trace for boa_tester Dec 2, 2022
@bors bors bot closed this Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants