[Merged by Bors] - Remove Literal::Undefined
#2518
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2518 +/- ##
=======================================
Coverage 51.58% 51.59%
=======================================
Files 356 355 -1
Lines 35666 35632 -34
=======================================
- Hits 18397 18383 -14
+ Misses 17269 17249 -20
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jedel1043
requested review from
HalidOdat,
Razican,
jasonwilliams,
nekevss,
RageKnify and
raskad
jedel1043
added
ast
jedel1043
approved these changes
Jan 6, 2023
raskad
approved these changes
Jan 7, 2023
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 7, 2023
<!--- Thank you for contributing to Boa! Please fill out the template below, and remove or add any information as you feel necessary. ---> This Pull Request fixes/closes #2512 . Removes `Literal::Undefined` so that `undefined` is treated as an identifier name. Ran the parser's idempotency fuzzer and ensured the bug doesn't reproduce.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Literal::UndefinedLiteral::Undefined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #2512 .
Removes
Literal::Undefinedso thatundefinedis treated as an identifier name. Ran the parser's idempotency fuzzer and ensured the bug doesn't reproduce.