Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Recognize Directive Prologues correctly #2521

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Recognize Directive Prologues correctly #2521

wants to merge 1 commit into from

Conversation

raskad
Copy link
Member

@raskad raskad commented Jan 7, 2023

This Pull Request changes the following:

  • Recognize the "use strict" directive prologue correctly.
  • Refactor parsers to remove a setter function.

@raskad raskad added bug Something isn't working parser Issues surrounding the parser labels Jan 7, 2023
@raskad raskad added this to the v0.17.0 milestone Jan 7, 2023
@github-actions
Copy link

github-actions bot commented Jan 7, 2023 •
edited

Test262 conformance changes

Test result main count PR count difference
Total 94,205 94,205 0
Passed 70,348 70,351 +3
Ignored 18,622 18,622 0
Failed 5,235 5,232 -3
Panics 0 0 0
Conformance 74.68% 74.68% +0.00%
Fixed tests (3): 
test/language/directive-prologue/14.1-14-s.js (previously Failed)
test/language/directive-prologue/14.1-8-s.js (previously Failed)
test/language/directive-prologue/14.1-5gs.js (previously Failed)

@codecov
Copy link

codecov bot commented Jan 7, 2023 •
edited

Codecov Report

Merging #2521 (390d7c0) into main (989edd4) will decrease coverage by 0.93%.
The diff coverage is 76.92%.

@@            Coverage Diff             @@
##             main    #2521      +/-   ##
==========================================
- Coverage   51.13%   50.20%   -0.94%     
==========================================
  Files         374      377       +3     
  Lines       36374    37006     +632     
==========================================
- Hits        18601    18579      -22     
- Misses      17773    18427     +654
Impacted Files Coverage Δ
boa_parser/src/parser/statement/block/mod.rs 73.52% <ø> (ø)
.../statement/declaration/hoistable/class_decl/mod.rs 50.64% <0.00%> (+0.07%) ⬆️
boa_parser/src/parser/statement/switch/mod.rs 75.00% <ø> (ø)
boa_parser/src/parser/mod.rs 66.66% <68.42%> (-4.94%) ⬇️
boa_parser/src/parser/statement/mod.rs 66.05% <93.33%> (+1.02%) ⬆️
boa_ast/src/statement_list.rs 78.84% <100.00%> (ø)
boa_parser/src/parser/function/mod.rs 60.13% <100.00%> (-3.46%) ⬇️
boa_engine/src/job.rs 84.61% <0.00%> (-15.39%) ⬇️
boa_engine/src/value/equality.rs 81.94% <0.00%> (-1.39%) ⬇️
boa_engine/src/object/operations.rs 66.40% <0.00%> (-1.08%) ⬇️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

jedel1043
jedel1043 approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@raskad raskad force-pushed the parse-directive-prologues branch 2 times, most recently from 4f74bd7 to 390d7c0 Compare January 14, 2023 02:44
jedel1043
jedel1043 approved these changes Jan 14, 2023
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good then!

nekevss
nekevss approved these changes Jan 15, 2023
View reviewed changes
Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 😄

@jedel1043
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jan 15, 2023
@raskad
Recognize Directive Prologues correctly (#2521)
f52d1d3 
This Pull Request changes the following:

- Recognize the `"use strict"` directive prologue correctly.
- Refactor parsers to remove a setter function.
@bors
Copy link

bors bot commented Jan 15, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Recognize Directive Prologues correctly [Merged by Bors] - Recognize Directive Prologues correctly Jan 15, 2023
@bors bors bot closed this Jan 15, 2023
@bors bors bot deleted the parse-directive-prologues branch January 15, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedel1043 jedel1043 jedel1043 approved these changes

@nekevss nekevss nekevss approved these changes

@Razican Razican Awaiting requested review from Razican

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

@HalidOdat HalidOdat Awaiting requested review from HalidOdat

@RageKnify RageKnify Awaiting requested review from RageKnify

Assignees
No one assigned
Labels
bug Something isn't working parser Issues surrounding the parser
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@raskad @jedel1043 @nekevss