Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Clarity changes for the VM #2531

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - Clarity changes for the VM #2531

wants to merge 6 commits into from

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Jan 14, 2023

Some small changes to the VM with the hopes of making it a bit more clear and concise.

It changes the following:

  • Changes code to code_block and code to bytecode in CallFrame and CodeBlock, respectively.
  • Adds some creation methods to CallFrame.
  • Implements Default for Vm.

@nekevss nekevss added the vm Issues and PRs related to the Boa Virtual Machine. label Jan 14, 2023
@nekevss nekevss added this to the v0.17.0 milestone Jan 14, 2023
@codecov
Copy link

codecov bot commented Jan 14, 2023 •
edited

Codecov Report

Merging #2531 (f486ca6) into main (f52d1d3) will decrease coverage by 0.18%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main    #2531      +/-   ##
==========================================
- Coverage   50.16%   49.97%   -0.19%     
==========================================
  Files         377      377              
  Lines       37469    37549      +80     
==========================================
- Hits        18795    18766      -29     
- Misses      18674    18783     +109
Impacted Files Coverage Δ
boa_engine/src/builtins/console/mod.rs 34.97% <0.00%> (ø)
boa_engine/src/vm/flowgraph/mod.rs 0.00% <0.00%> (ø)
boa_engine/src/vm/opcode/call/mod.rs 32.60% <0.00%> (ø)
boa_engine/src/vm/opcode/define/class/getter.rs 0.00% <0.00%> (ø)
boa_engine/src/vm/opcode/define/class/method.rs 0.00% <0.00%> (ø)
boa_engine/src/vm/opcode/define/class/setter.rs 0.00% <0.00%> (ø)
boa_engine/src/vm/opcode/get/generator.rs 0.00% <0.00%> (ø)
boa_engine/src/vm/opcode/get/private.rs 0.00% <0.00%> (ø)
boa_engine/src/vm/opcode/push/class/field.rs 0.00% <0.00%> (ø)
boa_engine/src/vm/opcode/push/class/private.rs 0.00% <0.00%> (ø)
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

jedel1043
jedel1043 approved these changes Jan 15, 2023
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvements!

Razican
Razican reviewed Jan 15, 2023
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much cleaner this way, thanks! I added some comments with potential enhancements to documentation.

boa_engine/src/vm/call_frame.rs Outdated Show resolved Hide resolved
boa_engine/src/vm/call_frame.rs Show resolved Hide resolved
@nekevss nekevss requested a review from Razican January 15, 2023 15:21
@nekevss nekevss requested a review from Razican January 15, 2023 21:22
Razican
Razican approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@Razican
Copy link
Member

Razican commented Jan 16, 2023

bors r+

bors bot pushed a commit that referenced this pull request Jan 16, 2023
@nekevss
Clarity changes for the VM (#2531)
ff06690 
<!---
Thank you for contributing to Boa! Please fill out the template below, and remove or add any
information as you feel necessary.
--->

Some small changes to the VM with the hopes of making it a bit more clear and concise.

It changes the following:

- Changes `code` to `code_block` and `code` to `bytecode` in `CallFrame` and `CodeBlock`, respectively.
- Adds some creation methods to `CallFrame`.
- Implements `Default` for `Vm`.
@bors
Copy link

bors bot commented Jan 16, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Clarity changes for the VM [Merged by Bors] - Clarity changes for the VM Jan 16, 2023
@bors bors bot closed this Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Razican Razican Razican approved these changes

@raskad raskad raskad approved these changes

@jedel1043 jedel1043 jedel1043 approved these changes

@HalidOdat HalidOdat Awaiting requested review from HalidOdat

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

@RageKnify RageKnify Awaiting requested review from RageKnify

Assignees
No one assigned
Labels
vm Issues and PRs related to the Boa Virtual Machine.
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nekevss @Razican @raskad @jedel1043