[Merged by Bors] - Fix double property access on assignment ops #2551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raskad
added
bug
Test262 conformance changes
Fixed tests (28): |
Codecov Report
@@ Coverage Diff @@
## main #2551 +/- ##
==========================================
- Coverage 49.99% 49.93% -0.06%
==========================================
Files 379 379
Lines 37642 37721 +79
==========================================
+ Hits 18819 18836 +17
- Misses 18823 18885 +62
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
raskad
requested review from
jedel1043,
HalidOdat,
jasonwilliams,
nekevss,
RageKnify and
Razican
jedel1043
reviewed
Jan 23, 2023
There was a problem hiding this comment.
A bit unfortunate that we can't share logic between simple accesses and assignments, but makes sense since they're special in the first place.
On another note, maybe we should split this function into compile_simple_assign and compile_assign_op, since they don't share any logic at all.
I thought this too. In the same change I would also refactor the AST to make it a bit typesafer. I'd like to push that in a follow up PR to keep the diff reasonable. |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 25, 2023
Currently the compilation of assignment operators leads to a double object property access, both on the get and set access. While this refactor adds special access handling instead of using the existing `access_set` and `access_get` functions, it fixes the double access and should also make the resulting code more efficient.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
bors bot
pushed a commit
that referenced
this pull request
Mar 25, 2023
Currently update expressions get values multiple times. This can lead to multiple executions of object property getters. This is very similar to #2551. Unfortunateley it seems like we have to sacrifice some code duplication for correctness in these cases. But that is probably for the best, as we can generate more optimized bytecode for each of these `get/set` cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the compilation of assignment operators leads to a double object property access, both on the get and set access.
While this refactor adds special access handling instead of using the existing
access_setandaccess_getfunctions, it fixes the double access and should also make the resulting code more efficient.