Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix string to number conversion for infinity #2607

Closed
wants to merge 1 commit into from

Conversation

raskad
Copy link
Member

@raskad raskad commented Feb 18, 2023

This Pull Request changes the following:

  • Fix string to number conversion for all invalid variants of infinity

@raskad raskad added bug Something isn't working execution Issues or PRs related to code execution labels Feb 18, 2023
@raskad raskad added this to the v0.17.0 milestone Feb 18, 2023
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 94,129 94,129 0
Passed 71,910 71,914 +4
Ignored 17,206 17,206 0
Failed 5,013 5,009 -4
Panics 12 12 0
Conformance 76.40% 76.40% +0.00%
Fixed tests (4):
test/built-ins/Number/S15.7.1.1_A1.js [strict mode] (previously Failed)
test/built-ins/Number/S15.7.1.1_A1.js (previously Failed)
test/language/expressions/unary-plus/S11.4.6_A3_T3.js [strict mode] (previously Failed)
test/language/expressions/unary-plus/S11.4.6_A3_T3.js (previously Failed)

@codecov
Copy link

codecov bot commented Feb 18, 2023

Codecov Report

Merging #2607 (3125ad3) into main (60c25b4) will increase coverage by 0.28%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2607      +/-   ##
==========================================
+ Coverage   49.34%   49.62%   +0.28%     
==========================================
  Files         386      386              
  Lines       38962    39073     +111     
==========================================
+ Hits        19224    19389     +165     
+ Misses      19738    19684      -54     
Impacted Files Coverage Δ
boa_engine/src/string/mod.rs 80.96% <100.00%> (-0.14%) ⬇️
boa_interner/src/lib.rs 82.35% <0.00%> (-1.69%) ⬇️
boa_engine/src/bytecompiler/statement/continue.rs 37.80% <0.00%> (-1.56%) ⬇️
...arser/src/parser/expression/left_hand_side/call.rs 52.30% <0.00%> (-1.54%) ⬇️
boa_parser/src/parser/function/mod.rs 58.64% <0.00%> (-1.49%) ⬇️
boa_parser/src/parser/statement/mod.rs 60.60% <0.00%> (-1.45%) ⬇️
boa_engine/src/value/equality.rs 81.94% <0.00%> (-1.39%) ⬇️
boa_engine/src/bytecompiler/statement/labelled.rs 51.42% <0.00%> (-1.35%) ⬇️
boa_parser/src/parser/expression/mod.rs 83.40% <0.00%> (-1.35%) ⬇️
boa_cli/src/main.rs 0.00% <0.00%> (-0.94%) ⬇️
... and 34 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@Razican
Copy link
Member

Razican commented Feb 18, 2023

Bors r+

bors bot pushed a commit that referenced this pull request Feb 18, 2023
This Pull Request changes the following:

- Fix string to number conversion for all invalid variants of `infinity`
@bors
Copy link

bors bot commented Feb 18, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix string to number conversion for infinity [Merged by Bors] - Fix string to number conversion for infinity Feb 18, 2023
@bors bors bot closed this Feb 18, 2023
@bors bors bot deleted the fix-to-number branch February 18, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working execution Issues or PRs related to code execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants