[Merged by Bors] - [Merged by Bors] - Decouple bytecompiler from CodeBlock #2669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalidOdat
force-pushed
the
refactor/CodeBlock
branch
2 times, most recently
from
d68cc24
to
8bec300
Compare
Test262 conformance changes
New panics (2): |
HalidOdat
force-pushed
the
refactor/CodeBlock
branch
2 times, most recently
from
c0e79bb
to
f03a3e7
Compare
Codecov Report
@@ Coverage Diff @@
## main #2669 +/- ##
==========================================
+ Coverage 49.70% 50.32% +0.62%
==========================================
Files 385 391 +6
Lines 39256 38788 -468
==========================================
+ Hits 19512 19521 +9
+ Misses 19744 19267 -477
... and 52 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
HalidOdat
force-pushed
the
refactor/CodeBlock
branch
from
f03a3e7
to
75edd12
Compare
Razican
approved these changes
Mar 15, 2023
| self.code_block.bytecode[index + 2] = bytes[1]; | ||
| self.code_block.bytecode[index + 3] = bytes[2]; | ||
| self.code_block.bytecode[index + 4] = bytes[3]; | ||
| self.bytecode[index + 1] = bytes[0]; |
There was a problem hiding this comment.
At some point we should check if this adds bound checking, and if we can do the bounds checking only once. Might enhance performance slightly.
There was a problem hiding this comment.
From my checking it seems that it does generate a bounds check per array access, my guess is that so it can give accurate panic locations if out-of-bounds
See generated assembly instructions: https://godbolt.org/z/q8azssz5K
There was a problem hiding this comment.
Explicitly checking beforehand and using a little unsafe we can remove the bounds checks: https://godbolt.org/z/bKT9ozr8s
It can create a PR after this one to address this :)
There was a problem hiding this comment.
Sometimes in Rust, if you check the full range before all the array access with an assert, it will remove all bounds checking without needing "unsafe". We would need to test that :)
There was a problem hiding this comment.
Yeah, but through by testing it doesn't seem so do so https://godbolt.org/z/q15WGh9n8 in this case...
Benchmark for 4d5e85dClick to view benchmark
|
raskad
approved these changes
Mar 15, 2023
This also give us some memory benefits, it reduces CodeBlock size from 264 => 208 (removes 56 bytes). Additionally calling `into_boxed_slice` If the vector has excess capacity, its items will be moved into a newly-allocated buffer with exactly the right capacity.
HalidOdat
force-pushed
the
refactor/CodeBlock
branch
from
75edd12
to
36cc7bd
Compare
Benchmark for 5a9e612Click to view benchmark
|
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 16, 2023
Hopefully this is a PR in a series of PRs to implement a bytecode optimizer, before that can happen there needs to be a lot of refactoring in the way we store and compile it. This also give us some memory benefits, it reduces `CodeBlock` size from `264` **=>** `208` (removes `56` bytes). Additionally when calling `into_boxed_slice`, If the vector has excess capacity, its items will be moved into a newly-allocated buffer with exactly the right capacity removing wasted space.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
bors bot
pushed a commit
that referenced
this pull request
Mar 17, 2023
As discussed in this comment #2669 (comment), `rustc` doesn't seem to optimize out the bounds checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this is a PR in a series of PRs to implement a bytecode optimizer, before that can happen there needs to be a lot of refactoring in the way we store and compile it.
This also give us some memory benefits, it reduces
CodeBlocksize from264=>208(removes56bytes).Additionally when calling
into_boxed_slice, If the vector has excess capacity, its items will be moved into a newly-allocated buffer with exactly the right capacity removing wasted space.