Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of forEach() #268

Merged
merged 3 commits into from Mar 8, 2020
Merged

Addition of forEach() #268

merged 3 commits into from Mar 8, 2020

Conversation

jasonwilliams
Copy link
Member

@jasonwilliams jasonwilliams commented Mar 6, 2020 •
edited

  • Taken from @xSke's older branch
  • Also some fixes to the debugger
  • Tests added

@jasonwilliams jasonwilliams mentioned this pull request Mar 6, 2020
Closed
@github-actions
Copy link

github-actions bot commented Mar 6, 2020

Benchmark for 7274a08

Click to view benchmark
Test PR Benchmark Master Benchmark %
Create Realm 378.5±33.38µs 399.3±25.44µs 95%
Expression (Parser) 10.4±0.64µs 8.8±0.66µs 119%
Hello World (Execution) 456.9±35.72µs 373.7±30.90µs 122%
Hello World (Lexer) 856.4±98.47ns 900.9±81.64ns 95%
Hello World (Parser) 1083.3±95.26ns 1115.0±99.80ns 97%
Symbol Creation 443.4±33.54µs 444.6±42.91µs 100%
fibonacci (Execution) 4.5±0.40ms 4.6±0.25ms 99%
undefined undefined 100%

Nickforall
Nickforall reviewed Mar 7, 2020
View reviewed changes
.vscode/launch.json Outdated
@@ -8,7 +8,7 @@
"type": "lldb",
"request": "launch",
"name": "Launch",
"program": "${workspaceFolder}/target/debug/boa_cli",
"program": "${workspaceFolder}/target/debug/boa_cli.exe",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose unix-like systems don't need the .exe extension? VSCode has support for platform specific properties in launch.json: https://code.visualstudio.com/Docs/editor/debugging#_platformspecific-properties

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you’re right well spotted!
I’ll change that, thanks

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@github-actions
Copy link

github-actions bot commented Mar 8, 2020

Benchmark for bc84c23

Click to view benchmark
Test PR Benchmark Master Benchmark %
Create Realm 424.1±21.79µs 430.9±20.27µs 98%
Expression (Parser) 10.3±0.36µs 10.5±0.81µs 98%
Hello World (Execution) 437.8±20.26µs 457.6±50.88µs 95%
Hello World (Lexer) 1061.0±53.29ns 1080.0±53.38ns 98%
Hello World (Parser) 1280.6±43.60ns 1302.1±47.54ns 98%
Symbol Creation 505.2±23.74µs 507.2±38.75µs 100%
fibonacci (Execution) 5.0±0.21ms 4.8±0.11ms 104%
undefined undefined 100%

@jasonwilliams jasonwilliams merged commit 9766409 into master Mar 8, 2020
@Nickforall Nickforall mentioned this pull request Mar 9, 2020
Merged
@jasonwilliams jasonwilliams deleted the forEach branch April 3, 2020 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nickforall Nickforall Nickforall left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jasonwilliams @Nickforall