[Merged by Bors] - Correctly run async tests #2683
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
added
bug
jedel1043
requested review from
Razican,
jasonwilliams,
HalidOdat,
RageKnify,
raskad and
nekevss
Codecov Report
@@ Coverage Diff @@
## main #2683 +/- ##
==========================================
+ Coverage 49.17% 49.49% +0.31%
==========================================
Files 397 393 -4
Lines 39748 39473 -275
==========================================
- Hits 19545 19536 -9
+ Misses 20203 19937 -266
... and 12 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Test262 conformance changes
Broken tests (1280): |
nekevss
reviewed
Mar 17, 2023
Razican
approved these changes
Mar 17, 2023
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 17, 2023
So, while working on #2658 I apparently broke 1280 tests... except I didn't! Turns out we were considering async tests that didn't call the `print` function as passed tests, but the `async` section of https://github.com/tc39/test262/blob/main/INTERPRETING.md#flags says: > The test must not be considered complete until the implementation-defined print function has been invoked or some length of time has passed without any such invocation.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, while working on #2658 I apparently broke 1280 tests... except I didn't! Turns out we were considering async tests that didn't call the
printfunction as passed tests, but theasyncsection of https://github.com/tc39/test262/blob/main/INTERPRETING.md#flags says: