Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix deserialization of SpecEdition #2762

Closed
wants to merge 1 commit into from

Conversation

jedel1043
Copy link
Member

@jedel1043 jedel1043 commented Mar 29, 2023

boa_tester wasn't deserializing SpecEdition correcly. This was because the attribute serde(untagged) just removes the u8 tag instead of trying to deserialize as a number. This PR fixes this using the serde_repr crate.

This needs #2763 to be merged for it to pass CI.

@jedel1043 jedel1043 added bug Something isn't working test Issues and PRs related to the tests. labels Mar 29, 2023
@jedel1043 jedel1043 added this to the v0.17.0 milestone Mar 29, 2023
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #2762 (6c1d57b) into main (cf85843) will increase coverage by 1.33%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2762      +/-   ##
==========================================
+ Coverage   50.96%   52.29%   +1.33%     
==========================================
  Files         397      392       -5     
  Lines       40009    39021     -988     
==========================================
+ Hits        20389    20405      +16     
+ Misses      19620    18616    -1004     

see 19 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 94,277 94,277 0
Passed 71,078 71,094 +16
Ignored 17,324 17,324 0
Failed 5,875 5,859 -16
Panics 0 0 0
Conformance 75.39% 75.41% +0.02%
Fixed tests (16):
test/harness/assertRelativeDateMs.js [strict mode] (previously Failed)
test/harness/assertRelativeDateMs.js (previously Failed)
test/built-ins/Date/S15.9.3.1_A5_T5.js [strict mode] (previously Failed)
test/built-ins/Date/S15.9.3.1_A5_T5.js (previously Failed)
test/built-ins/Date/S15.9.3.1_A5_T6.js [strict mode] (previously Failed)
test/built-ins/Date/S15.9.3.1_A5_T6.js (previously Failed)
test/built-ins/Date/S15.9.3.1_A5_T1.js [strict mode] (previously Failed)
test/built-ins/Date/S15.9.3.1_A5_T1.js (previously Failed)
test/built-ins/Date/S15.9.3.1_A5_T2.js [strict mode] (previously Failed)
test/built-ins/Date/S15.9.3.1_A5_T2.js (previously Failed)
test/built-ins/Date/S15.9.3.1_A5_T3.js [strict mode] (previously Failed)
test/built-ins/Date/S15.9.3.1_A5_T3.js (previously Failed)
test/built-ins/Date/S15.9.3.1_A5_T4.js [strict mode] (previously Failed)
test/built-ins/Date/S15.9.3.1_A5_T4.js (previously Failed)
test/built-ins/Date/prototype/toISOString/15.9.5.43-0-4.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/toISOString/15.9.5.43-0-4.js (previously Failed)

@jedel1043
Copy link
Member Author

All good!

@jedel1043
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Mar 29, 2023
`boa_tester` wasn't deserializing `SpecEdition` correcly. This was because the attribute `serde(untagged)` just removes the u8 tag instead of trying to deserialize as a number. This PR fixes this using the `serde_repr` crate.

This needs #2763 to be merged for it to pass CI.
@bors
Copy link

bors bot commented Mar 29, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix deserialization of SpecEdition [Merged by Bors] - Fix deserialization of SpecEdition Mar 29, 2023
@bors bors bot closed this Mar 29, 2023
@bors bors bot deleted the fix-version-serde branch March 29, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants