Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix TypedArrays minus zero key #2808

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Fix TypedArrays minus zero key #2808

wants to merge 2 commits into from

Conversation

HalidOdat
Copy link
Member

It changes the following:

  • Fix -0 index in typed arrays

@HalidOdat HalidOdat added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Apr 11, 2023
@HalidOdat HalidOdat added this to the v0.17.0 milestone Apr 11, 2023
@github-actions
Copy link

github-actions bot commented Apr 11, 2023 •
edited

Test262 conformance changes

Test result main count PR count difference
Total 94,781 94,781 0
Passed 71,489 71,501 +12
Ignored 17,824 17,824 0
Failed 5,468 5,456 -12
Panics 0 0 0
Conformance 75.43% 75.44% +0.01%
Fixed tests (12): 
test/built-ins/TypedArrayConstructors/internals/HasProperty/key-is-minus-zero.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/internals/HasProperty/key-is-minus-zero.js (previously Failed)
test/built-ins/TypedArrayConstructors/internals/HasProperty/BigInt/key-is-minus-zero.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/internals/HasProperty/BigInt/key-is-minus-zero.js (previously Failed)
test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/key-is-minus-zero.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/key-is-minus-zero.js (previously Failed)
test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-minus-zero.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-minus-zero.js (previously Failed)
test/built-ins/TypedArrayConstructors/internals/Get/key-is-not-minus-zero.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/internals/Get/key-is-not-minus-zero.js (previously Failed)
test/built-ins/TypedArrayConstructors/internals/Get/BigInt/key-is-not-minus-zero.js [strict mode] (previously Failed)
test/built-ins/TypedArrayConstructors/internals/Get/BigInt/key-is-not-minus-zero.js (previously Failed)

@Razican
Copy link
Member

Razican commented Apr 11, 2023

Hmmm are those broken tests expected?

@HalidOdat
Copy link
Member Author

HalidOdat commented Apr 11, 2023 •
edited

Hmmm are those broken tests expected?

I think this is caused because I need to check if it's detached first, converting this into a draft PR until it's fixed :)

@HalidOdat HalidOdat marked this pull request as draft April 11, 2023 21:31
@codecov
Copy link

codecov bot commented Apr 13, 2023 •
edited

Codecov Report

Merging #2808 (f35da7f) into main (4fbecb5) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##             main    #2808    +/-   ##
========================================
  Coverage   51.31%   51.31%            
========================================
  Files         416      417     +1     
  Lines       41213    41316   +103     
========================================
+ Hits        21149    21203    +54     
- Misses      20064    20113    +49
Impacted Files Coverage Δ
...ine/src/object/internal_methods/integer_indexed.rs 0.00% <0.00%> (ø)

... and 39 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@HalidOdat HalidOdat force-pushed the fix/typedarray-minus-zero-key branch from c385cd5 to f35da7f Compare April 13, 2023 04:23
@HalidOdat HalidOdat marked this pull request as ready for review April 13, 2023 04:35
@HalidOdat
Copy link
Member Author

I think this is caused because I need to check if it's detached first, converting this into a draft PR until it's fixed :)

Fixed! :)

Razican
Razican approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!! Great comments explaining deviations from the spec :)

jedel1043
jedel1043 approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@jedel1043
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Apr 14, 2023
@HalidOdat
Fix TypedArrays minus zero key (#2808)
bfa9815 
It changes the following:

- Fix `-0` index in typed arrays
@bors
Copy link

bors bot commented Apr 14, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix TypedArrays minus zero key [Merged by Bors] - Fix TypedArrays minus zero key Apr 14, 2023
@bors bors bot closed this Apr 14, 2023
@bors bors bot deleted the fix/typedarray-minus-zero-key branch April 14, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Razican Razican Razican approved these changes

@jedel1043 jedel1043 jedel1043 approved these changes

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

@RageKnify RageKnify Awaiting requested review from RageKnify

@raskad raskad Awaiting requested review from raskad

@nekevss nekevss Awaiting requested review from nekevss

Assignees
No one assigned
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HalidOdat @Razican @jedel1043