Add loop and switch return values #2828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raskad
added
bug
Test262 conformance changes
Fixed tests (76): |
raskad
requested review from
Razican,
jasonwilliams,
HalidOdat,
RageKnify,
jedel1043 and
nekevss
Codecov Report
@@ Coverage Diff @@
## main #2828 +/- ##
==========================================
+ Coverage 51.90% 51.96% +0.06%
==========================================
Files 431 431
Lines 43562 43657 +95
==========================================
+ Hits 22609 22686 +77
- Misses 20953 20971 +18
|
HalidOdat
approved these changes
Apr 18, 2023
raskad
force-pushed
the
loop-return-values
branch
2 times, most recently
from
c9a4df9
to
2d91f7a
Compare
|
Rebased. |
|
@jedel1043 I dont know if you already reviewed this or just enabled auto merge earlier, but now this is rebased again and ready. |
jedel1043
requested changes
May 7, 2023
| @@ -113,7 +80,45 @@ impl Operation for LoopEnd { | |||
| const INSTRUCTION: &'static str = "INST - LoopEnd"; | |||
|
|
|||
| fn execute(context: &mut Context<'_>) -> JsResult<CompletionType> { | |||
| cleanup_loop_environment(context); | |||
| //cleanup_loop_environment(context); | |||
There was a problem hiding this comment.
Suggested change
| //cleanup_loop_environment(context); |
| /// Set the loop return value for the current `EnvStackEntry`. | ||
| pub(crate) fn set_loop_return_value(&mut self, value: &JsValue) -> bool { | ||
| if let EnvEntryKind::Loop { value: v, .. } = &mut self.kind { | ||
| *v = value.clone(); |
There was a problem hiding this comment.
If we're assigning v anyways, maybe this should take value by value then.
Just enabled auto merge, but left my review moments ago |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request changes the following:
env_stackof theCallFrames.breakandcontinue.