Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix for-of expression parsing #2882

Closed
wants to merge 1 commit into from

Conversation

HalidOdat
Copy link
Member

@HalidOdat HalidOdat commented Apr 29, 2023

This PR makes parsing of expressions in for-of loops use AssignmentExpression expression parsing as defined in the spec.

@HalidOdat HalidOdat added bug Something isn't working parser Issues surrounding the parser labels Apr 29, 2023
@HalidOdat HalidOdat added this to the v0.17.0 milestone Apr 29, 2023
@github-actions
Copy link

github-actions bot commented Apr 29, 2023

Test262 conformance changes

Test result main count PR count difference
Total 94,593 94,593 0
Passed 73,200 73,206 +6
Ignored 17,532 17,532 0
Failed 3,861 3,855 -6
Panics 0 0 0
Conformance 77.38% 77.39% +0.01%
Fixed tests (6):
test/language/statements/for-of/head-var-no-expr.js [strict mode] (previously Failed)
test/language/statements/for-of/head-var-no-expr.js (previously Failed)
test/language/statements/for-of/head-decl-no-expr.js [strict mode] (previously Failed)
test/language/statements/for-of/head-decl-no-expr.js (previously Failed)
test/language/statements/for-of/head-expr-no-expr.js [strict mode] (previously Failed)
test/language/statements/for-of/head-expr-no-expr.js (previously Failed)

@HalidOdat HalidOdat force-pushed the fix/for-of-in-expression-parsing branch from 298dacd to a42fa02 Compare April 29, 2023 22:38
@codecov
Copy link

codecov bot commented Apr 29, 2023

Codecov Report

Merging #2882 (fb0d02a) into main (c738b50) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2882   +/-   ##
=======================================
  Coverage   51.24%   51.24%           
=======================================
  Files         427      427           
  Lines       42522    42525    +3     
=======================================
+ Hits        21790    21794    +4     
+ Misses      20732    20731    -1     
Impacted Files Coverage Δ
...er/src/parser/statement/iteration/for_statement.rs 56.50% <100.00%> (+0.66%) ⬆️

... and 1 file with indirect coverage changes

@HalidOdat HalidOdat changed the title Fix for-in/of expression parsing Fix for-of expression parsing Apr 29, 2023
@HalidOdat HalidOdat force-pushed the fix/for-of-in-expression-parsing branch from a42fa02 to 73740b0 Compare April 29, 2023 22:41
@HalidOdat HalidOdat marked this pull request as ready for review April 30, 2023 03:31
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@HalidOdat HalidOdat force-pushed the fix/for-of-in-expression-parsing branch from 73740b0 to fb0d02a Compare April 30, 2023 09:49
@raskad
Copy link
Member

raskad commented Apr 30, 2023

bors r+

bors bot pushed a commit that referenced this pull request Apr 30, 2023
This PR makes parsing of expressions in for-of loops use `AssignmentExpression` expression parsing as defined in the spec.
@bors
Copy link

bors bot commented Apr 30, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix for-of expression parsing [Merged by Bors] - Fix for-of expression parsing Apr 30, 2023
@bors bors bot closed this Apr 30, 2023
@bors bors bot deleted the fix/for-of-in-expression-parsing branch April 30, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working parser Issues surrounding the parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants