Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SyntaxErrors in GlobalDeclarationInstantiation #2908

Merged
merged 3 commits into from May 7, 2023
Merged

Conversation

raskad
Copy link
Member

@raskad raskad commented May 6, 2023

This Pull Request changes the following:

  • Add SyntaxErrors in GlobalDeclarationInstantiation.
  • Remove the unused Early phase in boa_tester.
  • Move the compilation from the parse to the runtime phase in boa_tester.

@raskad raskad added bug Something isn't working test Issues and PRs related to the tests. execution Issues or PRs related to code execution labels May 6, 2023
@raskad raskad added this to the v0.17.0 milestone May 6, 2023
@raskad raskad requested a review from a team May 6, 2023 01:42
@raskad raskad changed the title Fix global code Add SyntaxErrors in GlobalDeclarationInstantiation May 6, 2023
@github-actions
Copy link

github-actions bot commented May 6, 2023

Test262 conformance changes

Test result main count PR count difference
Total 94,601 94,601 0
Passed 73,345 73,355 +10
Ignored 17,505 17,505 0
Failed 3,751 3,741 -10
Panics 0 0 0
Conformance 77.53% 77.54% +0.01%
Fixed tests (10):
test/language/global-code/decl-lex-restricted-global.js [strict mode] (previously Failed)
test/language/global-code/decl-lex-restricted-global.js (previously Failed)
test/language/global-code/script-decl-lex-restricted-global.js [strict mode] (previously Failed)
test/language/global-code/script-decl-lex-restricted-global.js (previously Failed)
test/language/global-code/script-decl-lex-lex.js [strict mode] (previously Failed)
test/language/global-code/script-decl-lex-lex.js (previously Failed)
test/language/global-code/script-decl-var-collision.js [strict mode] (previously Failed)
test/language/global-code/script-decl-var-collision.js (previously Failed)
test/language/global-code/script-decl-lex-var.js [strict mode] (previously Failed)
test/language/global-code/script-decl-lex-var.js (previously Failed)

@codecov
Copy link

codecov bot commented May 6, 2023

Codecov Report

Merging #2908 (0cd9c1e) into main (c220505) will decrease coverage by 0.02%.
The diff coverage is 38.63%.

@@            Coverage Diff             @@
##             main    #2908      +/-   ##
==========================================
- Coverage   51.82%   51.81%   -0.02%     
==========================================
  Files         431      431              
  Lines       43302    43369      +67     
==========================================
+ Hits        22443    22473      +30     
- Misses      20859    20896      +37     
Impacted Files Coverage Δ
boa_tester/src/exec/mod.rs 0.00% <0.00%> (ø)
boa_tester/src/main.rs 0.00% <ø> (ø)
boa_engine/src/bytecompiler/declarations.rs 58.08% <47.05%> (-1.41%) ⬇️
boa_engine/src/context/mod.rs 49.70% <69.23%> (-2.01%) ⬇️

... and 9 files with indirect coverage changes

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! :)

@jedel1043 jedel1043 enabled auto-merge May 7, 2023 17:28
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looking good! Just had a small nitpick with an error message

boa_engine/src/bytecompiler/declarations.rs Outdated Show resolved Hide resolved
@jedel1043 jedel1043 added this pull request to the merge queue May 7, 2023
Merged via the queue into main with commit 719b5a1 May 7, 2023
9 checks passed
@raskad raskad deleted the fix-global-code branch May 7, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working execution Issues or PRs related to code execution test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants