Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remaining static module bugs #2955

Merged
merged 3 commits into from May 24, 2023
Merged

Fix remaining static module bugs #2955

merged 3 commits into from May 24, 2023

Conversation

jedel1043
Copy link
Member

@jedel1043 jedel1043 commented May 22, 2023

This Pull Request fixes our remaining module bugs in the test/language/module-code suite.
This leaves us with:

Results (ECMAScript Next):
Total tests: 581
Passed tests: 551
Ignored tests: 13
Failed tests: 17 (0 panics)
Conformance: 94.84%

16 tests are being fixed because they have an incorrect phase tag (tc39/test262#3832), and the 13 ignored tests are import assertions, which are still stage 3. Our true conformance status would be:

Results (ECMAScript Next):
Total tests: 581
Passed tests: 567
Ignored tests: 13
Failed tests: 1 (0 panics)
Conformance: 97.59%

The last failing test (test/language/module-code/eval-export-dflt-expr-cls-name-meth.js) seems to be a spec bug, but I'll investigate further.

@jedel1043 jedel1043 added bug Something isn't working test Issues and PRs related to the tests. execution Issues or PRs related to code execution labels May 22, 2023
@jedel1043 jedel1043 added this to the v0.17.0 milestone May 22, 2023
@jedel1043 jedel1043 requested a review from a team May 22, 2023 21:46
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 93,990 93,990 0
Passed 74,603 74,612 +9
Ignored 17,489 17,622 +133
Failed 1,898 1,756 -142
Panics 0 0 0
Conformance 79.37% 79.38% +0.01%
Fixed tests (16):
test/language/module-code/eval-export-dflt-expr-fn-anon.js (previously Failed)
test/language/module-code/export-expname-string-binding.js (previously Failed)
test/language/module-code/early-import-eval.js (previously Failed)
test/language/module-code/eval-rqstd-abrupt.js (previously Failed)
test/language/module-code/eval-export-dflt-expr-cls-anon.js (previously Failed)
test/language/module-code/eval-rqstd-order.js (previously Failed)
test/language/module-code/instn-star-as-props-dflt-skip.js (previously Failed)
test/language/module-code/verify-dfs.js (previously Failed)
test/language/module-code/export-star-as-dflt.js (previously Failed)
test/language/module-code/eval-export-dflt-expr-gen-anon.js (previously Failed)
test/language/module-code/export-expname-binding-index.js (previously Failed)
test/language/module-code/early-import-arguments.js (previously Failed)
test/language/module-code/instn-named-id-name.js (previously Failed)
test/language/expressions/dynamic-import/eval-export-dflt-expr-fn-anon.js (previously Failed)
test/language/expressions/dynamic-import/eval-export-dflt-expr-cls-anon.js (previously Failed)
test/language/expressions/dynamic-import/eval-export-dflt-expr-gen-anon.js (previously Failed)
Broken tests (2):
test/language/module-code/eval-export-dflt-expr-cls-name-meth.js (previously Passed)
test/language/expressions/dynamic-import/eval-export-dflt-expr-cls-name-meth.js (previously Passed)

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #2955 (cdb5e60) into main (09658b0) will decrease coverage by 0.09%.
The diff coverage is 14.68%.

@@            Coverage Diff             @@
##             main    #2955      +/-   ##
==========================================
- Coverage   50.15%   50.06%   -0.09%     
==========================================
  Files         446      446              
  Lines       45760    45851      +91     
==========================================
+ Hits        22951    22956       +5     
- Misses      22809    22895      +86     
Impacted Files Coverage Δ
boa_ast/src/declaration/export.rs 0.00% <0.00%> (ø)
boa_ast/src/module_item_list/mod.rs 0.00% <0.00%> (ø)
boa_engine/src/bytecompiler/env.rs 93.33% <ø> (ø)
boa_engine/src/bytecompiler/module.rs 0.00% <0.00%> (ø)
boa_engine/src/bytecompiler/statement/labelled.rs 65.21% <0.00%> (ø)
boa_engine/src/module/source.rs 0.00% <0.00%> (ø)
...ne/src/object/internal_methods/module_namespace.rs 0.00% <0.00%> (ø)
..._parser/src/parser/statement/declaration/export.rs 0.00% <0.00%> (ø)
..._parser/src/parser/statement/declaration/import.rs 0.00% <0.00%> (ø)
boa_engine/src/bytecompiler/declarations.rs 55.53% <20.00%> (ø)
... and 3 more

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@HalidOdat HalidOdat added this pull request to the merge queue May 24, 2023
Merged via the queue into main with commit 9bbe018 May 24, 2023
9 checks passed
@jedel1043 jedel1043 deleted the fix-module-bugs branch May 24, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working execution Issues or PRs related to code execution test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants