Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rust 1.70 lints #2990

Merged
merged 1 commit into from Jun 1, 2023
Merged

Fix rust 1.70 lints #2990

merged 1 commit into from Jun 1, 2023

Conversation

raskad
Copy link
Member

@raskad raskad commented Jun 1, 2023

This Pull Request fixes rust 1.70 lints.

@raskad raskad added the Internal Category for changelog label Jun 1, 2023
@raskad raskad added this to the v0.17.0 milestone Jun 1, 2023
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

Test262 conformance changes

Test result main count PR count difference
Total 94,118 94,118 0
Passed 74,620 74,620 0
Ignored 17,750 17,750 0
Failed 1,748 1,748 0
Panics 0 0 0
Conformance 79.28% 79.28% 0.00%

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@jedel1043 jedel1043 added this pull request to the merge queue Jun 1, 2023
@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #2990 (e58b751) into main (5794555) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2990      +/-   ##
==========================================
+ Coverage   50.20%   50.23%   +0.03%     
==========================================
  Files         446      446              
  Lines       45988    46000      +12     
==========================================
+ Hits        23089    23109      +20     
+ Misses      22899    22891       -8     
Impacted Files Coverage Δ
boa_engine/src/bytecompiler/statement/continue.rs 36.84% <ø> (-0.97%) ⬇️
boa_engine/src/string/mod.rs 74.44% <ø> (ø)
boa_engine/src/vm/opcode/rest_parameter/mod.rs 81.81% <100.00%> (ø)

... and 9 files with indirect coverage changes

Merged via the queue into main with commit 9367ee2 Jun 1, 2023
9 checks passed
@raskad raskad deleted the fix-rust-1.70-lints branch June 1, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Category for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants