Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for async module fetches #3012

Merged
merged 5 commits into from Feb 18, 2024
Merged

Add example for async module fetches #3012

merged 5 commits into from Feb 18, 2024

Conversation

jedel1043
Copy link
Member

This should probably be adapted to offer a similar feature in our playground, but with more resilience against connection errors.

@jedel1043 jedel1043 added enhancement New feature or request documentation update documentation labels Jun 8, 2023
@jedel1043 jedel1043 added this to the v0.17.0 milestone Jun 8, 2023
@jedel1043 jedel1043 requested a review from a team June 8, 2023 04:47
@github-actions
Copy link

github-actions bot commented Jun 8, 2023

Test262 conformance changes

Test result main count PR count difference
Total 50,268 50,268 0
Passed 42,549 42,549 0
Ignored 1,570 1,570 0
Failed 6,149 6,149 0
Panics 0 0 0
Conformance 84.64% 84.64% 0.00%

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Attention: 115 lines in your changes are missing coverage. Please review.

Comparison is base (6ddc2b4) 47.24% compared to head (b5d8f2b) 50.46%.
Report is 33 commits behind head on main.

❗ Current head b5d8f2b differs from pull request most recent head df87c31. Consider uploading reports for the commit df87c31 to get more accurate results

Files Patch % Lines
boa_examples/src/bin/module_fetch.rs 0.00% 115 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3012      +/-   ##
==========================================
+ Coverage   47.24%   50.46%   +3.21%     
==========================================
  Files         476      447      -29     
  Lines       46892    46035     -857     
==========================================
+ Hits        22154    23230    +1076     
+ Misses      24738    22805    -1933     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

boa_examples/src/bin/module_fetch.rs Outdated Show resolved Hide resolved
@jedel1043 jedel1043 requested review from HalidOdat and a team June 8, 2023 21:39
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest looks great! :)

boa_examples/src/bin/module_fetch.rs Outdated Show resolved Hide resolved
@jedel1043 jedel1043 requested a review from a team June 9, 2023 00:02
@jedel1043 jedel1043 requested a review from a team June 9, 2023 00:29
@Razican Razican modified the milestones: v0.17.0, v0.18.0 Jul 8, 2023
@jedel1043
Copy link
Member Author

I will rebase this ASAP to merge this.

@jedel1043 jedel1043 added the waiting-on-author Waiting on PR changes from the author label Nov 29, 2023
Copy link
Member

@raskad raskad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really useful example.

@raskad raskad added this pull request to the merge queue Feb 18, 2024
Merged via the queue into main with commit 736e4fb Feb 18, 2024
13 checks passed
@raskad raskad deleted the async-fetch-module branch February 18, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation update documentation enhancement New feature or request waiting-on-author Waiting on PR changes from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants