Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make IntegerIndexed::byte_offset public #3017

Merged
merged 1 commit into from Jun 16, 2023

Conversation

CryZe
Copy link
Contributor

@CryZe CryZe commented Jun 8, 2023

This allows querying the full range of the TypedArray in the underlying ArrayBuffer.

This allows querying the full range of the `TypedArray` in the
underlying `ArrayBuffer`.
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #3017 (0a8f3cd) into main (45e0b88) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3017      +/-   ##
==========================================
+ Coverage   50.56%   50.58%   +0.02%     
==========================================
  Files         446      446              
  Lines       45902    45920      +18     
==========================================
+ Hits        23210    23230      +20     
+ Misses      22692    22690       -2     
Impacted Files Coverage Δ
...src/builtins/typed_array/integer_indexed_object.rs 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm in favour of exposing this as a public accessor, since it's part of the properties that the spec defines for integer indexed objects.

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jedel1043 jedel1043 added enhancement New feature or request API labels Jun 16, 2023
@jedel1043 jedel1043 added this to the v0.17.0 milestone Jun 16, 2023
@jedel1043 jedel1043 added this pull request to the merge queue Jun 16, 2023
Merged via the queue into boa-dev:main with commit dfba57e Jun 16, 2023
9 checks passed
Razican pushed a commit that referenced this pull request Jun 26, 2023
This allows querying the full range of the `TypedArray` in the
underlying `ArrayBuffer`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants