Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypedArray.prototype.values() and TypedArray.prototype[@@iterator] should be equal #3096

Merged
merged 1 commit into from Jul 9, 2023
Merged

TypedArray.prototype.values() and TypedArray.prototype[@@iterator] should be equal #3096

merged 1 commit into from Jul 9, 2023

Conversation

HalidOdat
Copy link
Member

Make TypedArray.prototype.values() and `TypedArray.prototype[@@iterator] share the same function object.

@HalidOdat HalidOdat added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Jul 2, 2023
@HalidOdat HalidOdat changed the title TypedArray.prototype.values() and `TypedArray.prototype[@@iterator] should have the same value TypedArray.prototype.values() and TypedArray.prototype[@@iterator] should have the same value Jul 2, 2023
@HalidOdat HalidOdat changed the title TypedArray.prototype.values() and TypedArray.prototype[@@iterator] should have the same value TypedArray.prototype.values() and TypedArray.prototype[@@iterator] should be equal Jul 2, 2023
@HalidOdat HalidOdat requested a review from a team July 2, 2023 15:28
@github-actions
Copy link

github-actions bot commented Jul 2, 2023

Test262 conformance changes

Test result main count PR count difference
Total 94,842 94,842 0
Passed 74,691 74,693 +2
Ignored 18,812 18,812 0
Failed 1,339 1,337 -2
Panics 0 0 0
Conformance 78.75% 78.76% +0.00%
Fixed tests (2): 
test/built-ins/TypedArray/prototype/Symbol.iterator.js [strict mode] (previously Failed)
test/built-ins/TypedArray/prototype/Symbol.iterator.js (previously Failed)

@codecov
Copy link

codecov bot commented Jul 2, 2023

Codecov Report

Merging #3096 (48b2c22) into main (9b1f2f4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3096   +/-   ##
=======================================
  Coverage   50.42%   50.42%           
=======================================
  Files         444      444           
  Lines       45877    45878    +1     
=======================================
+ Hits        23132    23133    +1     
  Misses      22745    22745
Impacted Files Coverage Δ
boa_engine/src/builtins/typed_array/mod.rs 6.43% <100.00%> (+0.05%) ⬆️

@HalidOdat HalidOdat marked this pull request as ready for review July 3, 2023 11:29
jedel1043
jedel1043 approved these changes Jul 9, 2023
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@Razican Razican added this pull request to the merge queue Jul 9, 2023
Merged via the queue into main with commit 4baf6e2 Jul 9, 2023
9 checks passed
@HalidOdat HalidOdat deleted the fix/typedarray-prototype-values-method branch July 9, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Razican Razican Razican approved these changes

@jedel1043 jedel1043 jedel1043 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HalidOdat @Razican @jedel1043