Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change name field type in CodeBlock to JsString #3107

Merged
merged 2 commits into from Jul 9, 2023
Merged

Conversation

HalidOdat
Copy link
Member

Related #2626

@HalidOdat HalidOdat added the Internal Category for changelog label Jul 4, 2023
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Test262 conformance changes

Test result main count PR count difference
Total 94,842 94,842 0
Passed 74,691 74,691 0
Ignored 18,812 18,812 0
Failed 1,339 1,339 0
Panics 0 0 0
Conformance 78.75% 78.75% 0.00%

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #3107 (883b376) into main (9b1f2f4) will increase coverage by 0.25%.
The diff coverage is 29.16%.

@@            Coverage Diff             @@
##             main    #3107      +/-   ##
==========================================
+ Coverage   50.42%   50.67%   +0.25%     
==========================================
  Files         444      444              
  Lines       45877    42615    -3262     
==========================================
- Hits        23132    21594    -1538     
+ Misses      22745    21021    -1724     
Impacted Files Coverage Δ
boa_engine/src/vm/flowgraph/mod.rs 0.00% <0.00%> (ø)
boa_runtime/src/console/mod.rs 37.18% <0.00%> (-0.94%) ⬇️
boa_engine/src/vm/code_block.rs 59.62% <25.00%> (-1.39%) ⬇️
boa_engine/src/bytecompiler/mod.rs 67.59% <100.00%> (+0.04%) ⬆️

... and 185 files with indirect coverage changes

@HalidOdat HalidOdat requested a review from a team July 4, 2023 17:52
@raskad raskad added this to the v0.18.0 milestone Jul 9, 2023
@jedel1043 jedel1043 added this pull request to the merge queue Jul 9, 2023
Merged via the queue into main with commit 7ee922b Jul 9, 2023
9 checks passed
@HalidOdat HalidOdat deleted the sharable-code-blocks branch July 9, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Category for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants