Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rust-version to 1.71 #3290

Merged
merged 2 commits into from Sep 20, 2023
Merged

Bump rust-version to 1.71 #3290

merged 2 commits into from Sep 20, 2023

Conversation

jedel1043
Copy link
Member

Just to ensure our repo correctly reports our MSRV for users that want to use the main branch.

@jedel1043 jedel1043 added bug Something isn't working enhancement New feature or request labels Sep 19, 2023
@jedel1043 jedel1043 added this to the v0.18.0 milestone Sep 19, 2023
@jedel1043 jedel1043 requested a review from a team September 19, 2023 22:13
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 95,574 95,574 0
Passed 75,084 75,084 0
Ignored 19,494 19,494 0
Failed 996 996 0
Panics 0 0 0
Conformance 78.56% 78.56% 0.00%

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 50.00% and no project coverage change.

Comparison is base (8a78061) 50.31% compared to head (cca79fb) 50.31%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3290   +/-   ##
=======================================
  Coverage   50.31%   50.31%           
=======================================
  Files         436      436           
  Lines       42604    42604           
=======================================
  Hits        21438    21438           
  Misses      21166    21166           
Files Changed Coverage Δ
boa_engine/src/vm/opcode/mod.rs 7.03% <0.00%> (ø)
boa_engine/src/vm/code_block.rs 52.45% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

thought: Would it be worthwhile adding an MSRV test to our CI as well? I feel like we typically keep pretty close to current, but it could be useful to keep track of when we should increase the version.

@jedel1043
Copy link
Member Author

jedel1043 commented Sep 20, 2023

Would it be worthwhile adding an MSRV test to our CI as well?

I think #3173 does this, but we haven't got the time to review + merge it. Noope 😅

@nekevss
Copy link
Member

nekevss commented Sep 20, 2023

Hmmm, I think that's focused more on semver vs. msrv, right?

As an example, I think chrono uses dtolnay/rust-toolchain to run cargo test on a specified version to ensure a PR also compiles and runs on that version.

@jedel1043
Copy link
Member Author

Hmmm, I think that's focused more on semver vs. msrv, right?

Yeah, ignore that 😅 I was thinking that the msrv influenced semver, but I think those are orthogonal concepts.

@jedel1043 jedel1043 requested a review from a team September 20, 2023 04:03
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@jedel1043 jedel1043 added this pull request to the merge queue Sep 20, 2023
Merged via the queue into main with commit 986b048 Sep 20, 2023
9 checks passed
@Razican Razican mentioned this pull request Sep 20, 2023
@jedel1043 jedel1043 deleted the bump-msrv branch September 20, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants