Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make environments opcodes use varying operands #3340

Merged
merged 1 commit into from Oct 3, 2023

Conversation

HalidOdat
Copy link
Member

@HalidOdat HalidOdat commented Oct 2, 2023

Depends on #3332

Makes environment push opcodes that take index use varying operands, this required a bit of a refactor so we store environments pushed starting at zero, not in reversed order.

@HalidOdat HalidOdat added technical debt vm Issues and PRs related to the Boa Virtual Machine. labels Oct 2, 2023
@HalidOdat HalidOdat added this to the v0.18.0 milestone Oct 2, 2023
@HalidOdat HalidOdat requested a review from a team October 2, 2023 19:55
Base automatically changed from class-env-removal to main October 3, 2023 01:27
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Test262 conformance changes

Test result main count PR count difference
Total 95,574 95,574 0
Passed 75,273 75,273 0
Ignored 19,482 19,482 0
Failed 819 819 0
Panics 0 0 0
Conformance 78.76% 78.76% 0.00%

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (78bc9eb) 49.51% compared to head (175c434) 49.49%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3340      +/-   ##
==========================================
- Coverage   49.51%   49.49%   -0.03%     
==========================================
  Files         446      446              
  Lines       43777    43767      -10     
==========================================
- Hits        21678    21663      -15     
- Misses      22099    22104       +5     
Files Coverage Δ
boa_engine/src/builtins/eval/mod.rs 64.44% <100.00%> (-0.40%) ⬇️
boa_engine/src/bytecompiler/declarations.rs 51.40% <100.00%> (+0.11%) ⬆️
boa_engine/src/bytecompiler/env.rs 94.87% <100.00%> (ø)
boa_engine/src/bytecompiler/function.rs 100.00% <100.00%> (ø)
boa_engine/src/bytecompiler/statement/block.rs 100.00% <100.00%> (ø)
boa_engine/src/bytecompiler/statement/loop.rs 75.10% <100.00%> (-1.17%) ⬇️
boa_engine/src/bytecompiler/statement/switch.rs 100.00% <100.00%> (ø)
boa_engine/src/bytecompiler/statement/try.rs 90.90% <100.00%> (-0.11%) ⬇️
boa_engine/src/bytecompiler/statement/with.rs 100.00% <100.00%> (ø)
boa_engine/src/vm/opcode/mod.rs 5.32% <ø> (ø)
... and 3 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@raskad raskad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change!

@raskad raskad requested a review from a team October 3, 2023 22:34
@jedel1043 jedel1043 added this pull request to the merge queue Oct 3, 2023
Merged via the queue into main with commit a51581b Oct 3, 2023
14 checks passed
@jedel1043 jedel1043 deleted the refactor/environment-opcodes branch October 4, 2023 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical debt vm Issues and PRs related to the Boa Virtual Machine.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants