Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement change-array-by-copy methods #3412

Merged
merged 2 commits into from Oct 24, 2023
Merged

Implement change-array-by-copy methods #3412

merged 2 commits into from Oct 24, 2023

Conversation

jedel1043
Copy link
Member

This pull request implements our missing Array and TypedArray methods from ES14. Specifically:

  • Array.prototype.toReversed
  • Array.prototype.toSorted
  • Array.prototype.toSpliced
  • Array.prototype.with
  • TypedArray.prototype.toReversed
  • TypedArray.prototype.toSorted
  • TypedArray.prototype.with

@jedel1043 jedel1043 added enhancement New feature or request builtins PRs and Issues related to builtins/intrinsics labels Oct 23, 2023
@jedel1043 jedel1043 added this to the v0.18.0 milestone Oct 23, 2023
@jedel1043 jedel1043 requested a review from a team October 23, 2023 21:32
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 95,609 95,609 0
Passed 75,690 75,926 +236
Ignored 19,160 18,924 -236
Failed 759 759 0
Panics 0 0 0
Conformance 79.17% 79.41% +0.25%
Fixed tests (236): 
test/built-ins/TypedArray/prototype/toReversed/ignores-species.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/toReversed/ignores-species.js (previously Ignored)
test/built-ins/TypedArray/prototype/toReversed/not-a-constructor.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/toReversed/not-a-constructor.js (previously Ignored)
test/built-ins/TypedArray/prototype/toReversed/this-value-invalid.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/toReversed/this-value-invalid.js (previously Ignored)
test/built-ins/TypedArray/prototype/toReversed/immutable.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/toReversed/immutable.js (previously Ignored)
test/built-ins/TypedArray/prototype/toReversed/length-property-ignored.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/toReversed/length-property-ignored.js (previously Ignored)
test/built-ins/TypedArray/prototype/toReversed/metadata/property-descriptor.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/toReversed/metadata/property-descriptor.js (previously Ignored)
test/built-ins/TypedArray/prototype/toReversed/metadata/length.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/toReversed/metadata/length.js (previously Ignored)
test/built-ins/TypedArray/prototype/toReversed/metadata/name.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/toReversed/metadata/name.js (previously Ignored)
test/built-ins/TypedArray/prototype/with/index-bigger-or-eq-than-length.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/with/index-bigger-or-eq-than-length.js (previously Ignored)
test/built-ins/TypedArray/prototype/with/ignores-species.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/with/ignores-species.js (previously Ignored)
test/built-ins/TypedArray/prototype/with/index-casted-to-number.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/with/index-casted-to-number.js (previously Ignored)
test/built-ins/TypedArray/prototype/with/index-negative.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/with/index-negative.js (previously Ignored)
test/built-ins/TypedArray/prototype/with/not-a-constructor.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/with/not-a-constructor.js (previously Ignored)
test/built-ins/TypedArray/prototype/with/this-value-invalid.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/with/this-value-invalid.js (previously Ignored)
test/built-ins/TypedArray/prototype/with/immutable.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/with/immutable.js (previously Ignored)
test/built-ins/TypedArray/prototype/with/index-smaller-than-minus-length.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/with/index-smaller-than-minus-length.js (previously Ignored)
test/built-ins/TypedArray/prototype/with/early-type-coercion.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/with/early-type-coercion.js (previously Ignored)
test/built-ins/TypedArray/prototype/with/length-property-ignored.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/with/length-property-ignored.js (previously Ignored)
test/built-ins/TypedArray/prototype/with/BigInt/early-type-coercion-bigint.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/with/BigInt/early-type-coercion-bigint.js (previously Ignored)
test/built-ins/TypedArray/prototype/with/metadata/property-descriptor.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/with/metadata/property-descriptor.js (previously Ignored)
test/built-ins/TypedArray/prototype/with/metadata/length.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/with/metadata/length.js (previously Ignored)
test/built-ins/TypedArray/prototype/with/metadata/name.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/with/metadata/name.js (previously Ignored)
test/built-ins/TypedArray/prototype/toSorted/comparefn-stop-after-error.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/toSorted/comparefn-stop-after-error.js (previously Ignored)
test/built-ins/TypedArray/prototype/toSorted/ignores-species.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/toSorted/ignores-species.js (previously Ignored)
test/built-ins/TypedArray/prototype/toSorted/comparefn-not-a-function.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/toSorted/comparefn-not-a-function.js (previously Ignored)
test/built-ins/TypedArray/prototype/toSorted/not-a-constructor.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/toSorted/not-a-constructor.js (previously Ignored)
test/built-ins/TypedArray/prototype/toSorted/this-value-invalid.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/toSorted/this-value-invalid.js (previously Ignored)
test/built-ins/TypedArray/prototype/toSorted/immutable.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/toSorted/immutable.js (previously Ignored)
test/built-ins/TypedArray/prototype/toSorted/length-property-ignored.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/toSorted/length-property-ignored.js (previously Ignored)
test/built-ins/TypedArray/prototype/toSorted/metadata/property-descriptor.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/toSorted/metadata/property-descriptor.js (previously Ignored)
test/built-ins/TypedArray/prototype/toSorted/metadata/length.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/toSorted/metadata/length.js (previously Ignored)
test/built-ins/TypedArray/prototype/toSorted/metadata/name.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/toSorted/metadata/name.js (previously Ignored)
test/built-ins/Array/prototype/toReversed/this-value-nullish.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toReversed/this-value-nullish.js (previously Ignored)
test/built-ins/Array/prototype/toReversed/ignores-species.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toReversed/ignores-species.js (previously Ignored)
test/built-ins/Array/prototype/toReversed/holes-not-preserved.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toReversed/holes-not-preserved.js (previously Ignored)
test/built-ins/Array/prototype/toReversed/get-descending-order.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toReversed/get-descending-order.js (previously Ignored)
test/built-ins/Array/prototype/toReversed/length-tolength.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toReversed/length-tolength.js (previously Ignored)
test/built-ins/Array/prototype/toReversed/this-value-boolean.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toReversed/this-value-boolean.js (previously Ignored)
test/built-ins/Array/prototype/toReversed/zero-or-one-element.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toReversed/zero-or-one-element.js (previously Ignored)
test/built-ins/Array/prototype/toReversed/length-decreased-while-iterating.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toReversed/length-decreased-while-iterating.js (previously Ignored)
test/built-ins/Array/prototype/toReversed/length-exceeding-array-length-limit.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toReversed/length-exceeding-array-length-limit.js (previously Ignored)
test/built-ins/Array/prototype/toReversed/length-increased-while-iterating.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toReversed/length-increased-while-iterating.js (previously Ignored)
test/built-ins/Array/prototype/toReversed/frozen-this-value.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toReversed/frozen-this-value.js (previously Ignored)
test/built-ins/Array/prototype/toReversed/not-a-constructor.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toReversed/not-a-constructor.js (previously Ignored)
test/built-ins/Array/prototype/toReversed/length-casted-to-zero.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toReversed/length-casted-to-zero.js (previously Ignored)
test/built-ins/Array/prototype/toReversed/immutable.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toReversed/immutable.js (previously Ignored)
test/built-ins/Array/prototype/toReversed/metadata/property-descriptor.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toReversed/metadata/property-descriptor.js (previously Ignored)
test/built-ins/Array/prototype/toReversed/metadata/length.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toReversed/metadata/length.js (previously Ignored)
test/built-ins/Array/prototype/toReversed/metadata/name.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toReversed/metadata/name.js (previously Ignored)
test/built-ins/Array/prototype/with/index-bigger-or-eq-than-length.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/with/index-bigger-or-eq-than-length.js (previously Ignored)
test/built-ins/Array/prototype/with/this-value-nullish.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/with/this-value-nullish.js (previously Ignored)
test/built-ins/Array/prototype/with/ignores-species.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/with/ignores-species.js (previously Ignored)
test/built-ins/Array/prototype/with/holes-not-preserved.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/with/holes-not-preserved.js (previously Ignored)
test/built-ins/Array/prototype/with/length-tolength.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/with/length-tolength.js (previously Ignored)
test/built-ins/Array/prototype/with/this-value-boolean.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/with/this-value-boolean.js (previously Ignored)
test/built-ins/Array/prototype/with/index-casted-to-number.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/with/index-casted-to-number.js (previously Ignored)
test/built-ins/Array/prototype/with/length-decreased-while-iterating.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/with/length-decreased-while-iterating.js (previously Ignored)
test/built-ins/Array/prototype/with/length-exceeding-array-length-limit.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/with/length-exceeding-array-length-limit.js (previously Ignored)
test/built-ins/Array/prototype/with/index-negative.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/with/index-negative.js (previously Ignored)
test/built-ins/Array/prototype/with/length-increased-while-iterating.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/with/length-increased-while-iterating.js (previously Ignored)
test/built-ins/Array/prototype/with/frozen-this-value.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/with/frozen-this-value.js (previously Ignored)
test/built-ins/Array/prototype/with/no-get-replaced-index.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/with/no-get-replaced-index.js (previously Ignored)
test/built-ins/Array/prototype/with/not-a-constructor.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/with/not-a-constructor.js (previously Ignored)
test/built-ins/Array/prototype/with/immutable.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/with/immutable.js (previously Ignored)
test/built-ins/Array/prototype/with/index-smaller-than-minus-length.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/with/index-smaller-than-minus-length.js (previously Ignored)
test/built-ins/Array/prototype/with/metadata/property-descriptor.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/with/metadata/property-descriptor.js (previously Ignored)
test/built-ins/Array/prototype/with/metadata/length.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/with/metadata/length.js (previously Ignored)
test/built-ins/Array/prototype/with/metadata/name.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/with/metadata/name.js (previously Ignored)
test/built-ins/Array/prototype/toSpliced/start-neg-subtracted-from-length.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSpliced/start-neg-subtracted-from-length.js (previously Ignored)
test/built-ins/Array/prototype/toSpliced/start-and-deleteCount-missing.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSpliced/start-and-deleteCount-missing.js (previously Ignored)
test/built-ins/Array/prototype/toSpliced/this-value-nullish.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSpliced/this-value-nullish.js (previously Ignored)
test/built-ins/Array/prototype/toSpliced/deleteCount-undefined.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSpliced/deleteCount-undefined.js (previously Ignored)
test/built-ins/Array/prototype/toSpliced/elements-read-in-order.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSpliced/elements-read-in-order.js (previously Ignored)
test/built-ins/Array/prototype/toSpliced/ignores-species.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSpliced/ignores-species.js (previously Ignored)
test/built-ins/Array/prototype/toSpliced/unmodified.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSpliced/unmodified.js (previously Ignored)
test/built-ins/Array/prototype/toSpliced/holes-not-preserved.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSpliced/holes-not-preserved.js (previously Ignored)
test/built-ins/Array/prototype/toSpliced/length-tolength.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSpliced/length-tolength.js (previously Ignored)
test/built-ins/Array/prototype/toSpliced/this-value-boolean.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSpliced/this-value-boolean.js (previously Ignored)
test/built-ins/Array/prototype/toSpliced/discarded-element-not-read.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSpliced/discarded-element-not-read.js (previously Ignored)
test/built-ins/Array/prototype/toSpliced/deleteCount-missing.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSpliced/deleteCount-missing.js (previously Ignored)
test/built-ins/Array/prototype/toSpliced/length-decreased-while-iterating.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSpliced/length-decreased-while-iterating.js (previously Ignored)
test/built-ins/Array/prototype/toSpliced/start-bigger-than-length.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSpliced/start-bigger-than-length.js (previously Ignored)
test/built-ins/Array/prototype/toSpliced/length-clamped-to-2pow53minus1.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSpliced/length-clamped-to-2pow53minus1.js (previously Ignored)
test/built-ins/Array/prototype/toSpliced/length-exceeding-array-length-limit.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSpliced/length-exceeding-array-length-limit.js (previously Ignored)
test/built-ins/Array/prototype/toSpliced/mutate-while-iterating.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSpliced/mutate-while-iterating.js (previously Ignored)
test/built-ins/Array/prototype/toSpliced/start-undefined-and-deleteCount-missing.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSpliced/start-undefined-and-deleteCount-missing.js (previously Ignored)
test/built-ins/Array/prototype/toSpliced/length-increased-while-iterating.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSpliced/length-increased-while-iterating.js (previously Ignored)
test/built-ins/Array/prototype/toSpliced/frozen-this-value.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSpliced/frozen-this-value.js (previously Ignored)
test/built-ins/Array/prototype/toSpliced/start-neg-less-than-minus-length-is-zero.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSpliced/start-neg-less-than-minus-length-is-zero.js (previously Ignored)
test/built-ins/Array/prototype/toSpliced/start-neg-infinity-is-zero.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSpliced/start-neg-infinity-is-zero.js (previously Ignored)
test/built-ins/Array/prototype/toSpliced/not-a-constructor.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSpliced/not-a-constructor.js (previously Ignored)
test/built-ins/Array/prototype/toSpliced/length-casted-to-zero.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSpliced/length-casted-to-zero.js (previously Ignored)
test/built-ins/Array/prototype/toSpliced/start-and-deleteCount-undefineds.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSpliced/start-and-deleteCount-undefineds.js (previously Ignored)
test/built-ins/Array/prototype/toSpliced/immutable.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSpliced/immutable.js (previously Ignored)
test/built-ins/Array/prototype/toSpliced/deleteCount-clamped-between-zero-and-remaining-count.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSpliced/deleteCount-clamped-between-zero-and-remaining-count.js (previously Ignored)
test/built-ins/Array/prototype/toSpliced/metadata/property-descriptor.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSpliced/metadata/property-descriptor.js (previously Ignored)
test/built-ins/Array/prototype/toSpliced/metadata/length.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSpliced/metadata/length.js (previously Ignored)
test/built-ins/Array/prototype/toSpliced/metadata/name.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSpliced/metadata/name.js (previously Ignored)
test/built-ins/Array/prototype/Symbol.unscopables/change-array-by-copy.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/Symbol.unscopables/change-array-by-copy.js (previously Ignored)
test/built-ins/Array/prototype/toSorted/comparefn-stop-after-error.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSorted/comparefn-stop-after-error.js (previously Ignored)
test/built-ins/Array/prototype/toSorted/this-value-nullish.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSorted/this-value-nullish.js (previously Ignored)
test/built-ins/Array/prototype/toSorted/ignores-species.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSorted/ignores-species.js (previously Ignored)
test/built-ins/Array/prototype/toSorted/holes-not-preserved.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSorted/holes-not-preserved.js (previously Ignored)
test/built-ins/Array/prototype/toSorted/comparefn-not-a-function.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSorted/comparefn-not-a-function.js (previously Ignored)
test/built-ins/Array/prototype/toSorted/length-tolength.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSorted/length-tolength.js (previously Ignored)
test/built-ins/Array/prototype/toSorted/this-value-boolean.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSorted/this-value-boolean.js (previously Ignored)
test/built-ins/Array/prototype/toSorted/zero-or-one-element.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSorted/zero-or-one-element.js (previously Ignored)
test/built-ins/Array/prototype/toSorted/length-decreased-while-iterating.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSorted/length-decreased-while-iterating.js (previously Ignored)
test/built-ins/Array/prototype/toSorted/length-exceeding-array-length-limit.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSorted/length-exceeding-array-length-limit.js (previously Ignored)
test/built-ins/Array/prototype/toSorted/length-increased-while-iterating.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSorted/length-increased-while-iterating.js (previously Ignored)
test/built-ins/Array/prototype/toSorted/frozen-this-value.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSorted/frozen-this-value.js (previously Ignored)
test/built-ins/Array/prototype/toSorted/not-a-constructor.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSorted/not-a-constructor.js (previously Ignored)
test/built-ins/Array/prototype/toSorted/length-casted-to-zero.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSorted/length-casted-to-zero.js (previously Ignored)
test/built-ins/Array/prototype/toSorted/comparefn-called-after-get-elements.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSorted/comparefn-called-after-get-elements.js (previously Ignored)
test/built-ins/Array/prototype/toSorted/immutable.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSorted/immutable.js (previously Ignored)
test/built-ins/Array/prototype/toSorted/metadata/property-descriptor.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSorted/metadata/property-descriptor.js (previously Ignored)
test/built-ins/Array/prototype/toSorted/metadata/length.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSorted/metadata/length.js (previously Ignored)
test/built-ins/Array/prototype/toSorted/metadata/name.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/toSorted/metadata/name.js (previously Ignored)

@codecov
Copy link

codecov bot commented Oct 23, 2023 •
edited

Codecov Report

Attention: 325 lines in your changes are missing coverage. Please review.

Comparison is base (cec9892) 45.64% compared to head (464df2e) 45.45%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3412      +/-   ##
==========================================
- Coverage   45.64%   45.45%   -0.19%     
==========================================
  Files         483      483              
  Lines       49517    49743     +226     
==========================================
+ Hits        22600    22613      +13     
- Misses      26917    27130     +213
Files Coverage Δ
boa_engine/src/builtins/typed_array/mod.rs 14.63% <ø> (ø)
...ine/src/object/internal_methods/integer_indexed.rs 0.00% <ø> (ø)
boa_engine/src/object/builtins/jsarray.rs 3.59% <0.00%> (-0.72%) ⬇️
boa_engine/src/object/builtins/jstypedarray.rs 0.00% <0.00%> (ø)
boa_engine/src/builtins/typed_array/builtin.rs 5.98% <2.63%> (-0.21%) ⬇️
boa_engine/src/builtins/array/mod.rs 71.08% <40.10%> (-5.27%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

HalidOdat
HalidOdat approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Just some small nitpicks on the spec doc indentation, the rest looks good to me! :)

boa_engine/src/builtins/array/mod.rs Outdated Show resolved Hide resolved
boa_engine/src/builtins/array/mod.rs Outdated Show resolved Hide resolved
@HalidOdat HalidOdat requested a review from a team October 24, 2023 05:25
nekevss
nekevss approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 😄

@nekevss nekevss added this pull request to the merge queue Oct 24, 2023
Merged via the queue into main with commit 432deee Oct 24, 2023
14 checks passed
@jedel1043 jedel1043 deleted the change-array-by-copy branch October 28, 2023 06:40
sam-finch-tezos pushed a commit to trilitech/boa that referenced this pull request Nov 29, 2023
@jedel1043 @sam-finch-tezos
Implement change-array-by-copy methods (boa-dev#3412)
1da23e4 
* Implement `change-array-by-copy` methods

* Apply review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HalidOdat HalidOdat HalidOdat approved these changes

@nekevss nekevss nekevss approved these changes

Assignees
No one assigned
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Projects
None yet
Milestone
v0.18.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jedel1043 @HalidOdat @nekevss