[[HostDefined]] Improvements
#3460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnyob
force-pushed
the
ajob410@host-defined-refactor-2
branch
from
d5f18f8
to
fe26dbd
Compare
jedel1043
requested changes
Nov 8, 2023
johnyob
force-pushed
the
ajob410@host-defined-refactor-2
branch
from
fe26dbd
to
ab6a9f1
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3460 +/- ##
==========================================
- Coverage 44.65% 44.62% -0.04%
==========================================
Files 487 487
Lines 50503 50541 +38
==========================================
Hits 22554 22554
- Misses 27949 27987 +38
☔ View full report in Codecov by Sentry. |
johnyob
force-pushed
the
ajob410@host-defined-refactor-2
branch
from
ab6a9f1
to
79279ad
Compare
Currently `[[HostDefined]]` doesn't permit you to mutably borrow two objects from the `[[HostDefined]]` field since the `FxHashMap` is wrapped under a `GcRefCell`. This commit implements a `get_mut_many` (from `hashbrown`'s `HashMap`) method to permit accessing several `NativeObject`s using a `NativeTuple`. Additionally, this commit takes the opportunity to provide automatic downcasting on the `insert` and `remove` methods for `[[HostDefined]]`.
johnyob
force-pushed
the
ajob410@host-defined-refactor-2
branch
from
79279ad
to
022ee6a
Compare
HalidOdat
approved these changes
Nov 10, 2023
raskad
approved these changes
Nov 10, 2023
ahaoboy
pushed a commit
to ahaoboy/boa
that referenced
this pull request
Nov 15, 2023
* Refactor the `[[HostDefined]]` implementation. Currently `[[HostDefined]]` doesn't permit you to mutably borrow two objects from the `[[HostDefined]]` field since the `FxHashMap` is wrapped under a `GcRefCell`. This commit implements a `get_mut_many` (from `hashbrown`'s `HashMap`) method to permit accessing several `NativeObject`s using a `NativeTuple`. Additionally, this commit takes the opportunity to provide automatic downcasting on the `insert` and `remove` methods for `[[HostDefined]]`. * Update `[[HostDefined]]` example.
ahaoboy
pushed a commit
to ahaoboy/boa
that referenced
this pull request
Nov 15, 2023
* Refactor the `[[HostDefined]]` implementation. Currently `[[HostDefined]]` doesn't permit you to mutably borrow two objects from the `[[HostDefined]]` field since the `FxHashMap` is wrapped under a `GcRefCell`. This commit implements a `get_mut_many` (from `hashbrown`'s `HashMap`) method to permit accessing several `NativeObject`s using a `NativeTuple`. Additionally, this commit takes the opportunity to provide automatic downcasting on the `insert` and `remove` methods for `[[HostDefined]]`. * Update `[[HostDefined]]` example.
sam-finch-tezos
pushed a commit
to trilitech/boa
that referenced
this pull request
Nov 29, 2023
* Refactor the `[[HostDefined]]` implementation. Currently `[[HostDefined]]` doesn't permit you to mutably borrow two objects from the `[[HostDefined]]` field since the `FxHashMap` is wrapped under a `GcRefCell`. This commit implements a `get_mut_many` (from `hashbrown`'s `HashMap`) method to permit accessing several `NativeObject`s using a `NativeTuple`. Additionally, this commit takes the opportunity to provide automatic downcasting on the `insert` and `remove` methods for `[[HostDefined]]`. * Update `[[HostDefined]]` example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Related PRs: #3370
Currently
HostDefineddoesn't permit you to mutably borrow two objects from the[[HostDefined]]field since theFxHashMapis wrapped under aGcRefCell.Description
This PR implements a
get_mut_many(fromhashbrown'sHashMap) method to permit accessing severalNativeObjects using aNativeTuple.Additionally, this commit takes the opportunity to provide automatic downcasting on the
insertandremovemethods for[[HostDefined]].