Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utility methods to the Class trait #3488

Merged
merged 1 commit into from Nov 29, 2023
Merged

Add utility methods to the Class trait #3488

merged 1 commit into from Nov 29, 2023

Conversation

jedel1043
Copy link
Member

Adds some requested utilities for our Class trait.

@jedel1043 jedel1043 added enhancement New feature or request API labels Nov 29, 2023
@jedel1043 jedel1043 added this to the v0.18.0 milestone Nov 29, 2023
@jedel1043 jedel1043 requested a review from a team November 29, 2023 08:34
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (5274b91) 44.59% compared to head (b2c848a) 44.57%.

Files Patch % Lines
boa_engine/src/class.rs 0.00% 27 Missing ⚠️
boa_engine/src/object/mod.rs 20.00% 4 Missing ⚠️
boa_examples/src/bin/classes.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3488      +/-   ##
==========================================
- Coverage   44.59%   44.57%   -0.02%     
==========================================
  Files         487      487              
  Lines       50601    50621      +20     
==========================================
  Hits        22563    22563              
- Misses      28038    28058      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Test262 conformance changes

Test result main count PR count difference
Total 95,609 95,609 0
Passed 76,526 76,526 0
Ignored 18,132 18,132 0
Failed 951 951 0
Panics 0 0 0
Conformance 80.04% 80.04% 0.00%

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@HalidOdat HalidOdat requested a review from a team November 29, 2023 13:35
@nekevss nekevss added this pull request to the merge queue Nov 29, 2023
Merged via the queue into main with commit 9f181ef Nov 29, 2023
14 checks passed
@jedel1043 jedel1043 deleted the class-api-utils branch November 29, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants