Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Icu API #3503

Merged
merged 4 commits into from Dec 7, 2023
Merged

Simplify Icu API #3503

merged 4 commits into from Dec 7, 2023

Conversation

jedel1043
Copy link
Member

Hides BoaProvider to be crate-private, which makes the overall API easier for users.

@jedel1043 jedel1043 added enhancement New feature or request API labels Dec 5, 2023
@jedel1043 jedel1043 added this to the v0.18.0 milestone Dec 5, 2023
@jedel1043 jedel1043 requested a review from a team December 5, 2023 21:15
@jedel1043 jedel1043 marked this pull request as ready for review December 5, 2023 21:15
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 50 lines in your changes are missing coverage. Please review.

Comparison is base (47351ef) 49.01% compared to head (a9ae59f) 48.99%.
Report is 1 commits behind head on main.

Files Patch % Lines
core/engine/src/context/icu.rs 56.52% 10 Missing ⚠️
core/engine/src/builtins/intl/locale/mod.rs 0.00% 8 Missing ⚠️
core/engine/src/context/mod.rs 11.11% 8 Missing ⚠️
core/engine/src/builtins/intl/collator/mod.rs 0.00% 5 Missing ⚠️
core/engine/src/builtins/intl/list_format/mod.rs 0.00% 4 Missing ⚠️
core/engine/src/builtins/intl/locale/utils.rs 73.33% 4 Missing ⚠️
core/engine/src/builtins/intl/segmenter/mod.rs 0.00% 4 Missing ⚠️
core/engine/src/builtins/string/mod.rs 0.00% 4 Missing ⚠️
core/engine/src/builtins/intl/plural_rules/mod.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3503      +/-   ##
==========================================
- Coverage   49.01%   48.99%   -0.02%     
==========================================
  Files         469      469              
  Lines       48186    48192       +6     
==========================================
- Hits        23618    23613       -5     
- Misses      24568    24579      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 5, 2023

Test262 conformance changes

Test result main count PR count difference
Total 95,960 95,960 0
Passed 76,534 76,534 0
Ignored 18,477 18,477 0
Failed 949 949 0
Panics 0 0 0
Conformance 79.76% 79.76% 0.00%

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@HalidOdat HalidOdat requested a review from a team December 6, 2023 23:14
Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it needs a rebase. But everything else looks good to me!

@jedel1043 jedel1043 added this pull request to the merge queue Dec 7, 2023
Merged via the queue into main with commit 52b39fa Dec 7, 2023
15 checks passed
@jedel1043 jedel1043 deleted the simpler-intl-api branch December 9, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants