Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement inline caching tests and cleanup #3513

Merged
merged 1 commit into from Feb 6, 2024
Merged

Conversation

HalidOdat
Copy link
Member

@HalidOdat HalidOdat commented Dec 10, 2023

It changes the following:

  • Implements some tests for internal method inline chaching
  • Test object internal methods
  • Test Get and Set inline caching opcodes
  • Cleanup

@HalidOdat HalidOdat added execution Issues or PRs related to code execution vm Issues and PRs related to the Boa Virtual Machine. labels Dec 10, 2023
Copy link

github-actions bot commented Dec 10, 2023

Test262 conformance changes

Test result main count PR count difference
Total 96,310 96,310 0
Passed 80,819 80,819 0
Ignored 3,681 3,681 0
Failed 11,810 11,810 0
Panics 0 0 0
Conformance 83.92% 83.92% 0.00%

Copy link

codecov bot commented Dec 10, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (6ddc2b4) 47.24% compared to head (3681768) 48.87%.
Report is 15 commits behind head on main.

❗ Current head 3681768 differs from pull request most recent head 96302de. Consider uploading reports for the commit 96302de to get more accurate results

Files Patch % Lines
core/engine/src/vm/opcode/set/property.rs 46.15% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3513      +/-   ##
==========================================
+ Coverage   47.24%   48.87%   +1.63%     
==========================================
  Files         476      472       -4     
  Lines       46892    48500    +1608     
==========================================
+ Hits        22154    23705    +1551     
- Misses      24738    24795      +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HalidOdat HalidOdat force-pushed the inline-caching-tests branch 2 times, most recently from 402a4c0 to b1a53e7 Compare February 2, 2024 14:11
@HalidOdat HalidOdat marked this pull request as ready for review February 2, 2024 14:13
@HalidOdat HalidOdat added this to the v0.18.0 milestone Feb 2, 2024
@HalidOdat HalidOdat requested a review from a team February 2, 2024 14:13
@nekevss nekevss added the waiting-on-review Waiting on reviews from the maintainers label Feb 6, 2024
Copy link
Member

@raskad raskad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice refactor!

@raskad raskad requested a review from a team February 6, 2024 18:52
@jedel1043 jedel1043 added this pull request to the merge queue Feb 6, 2024
Merged via the queue into main with commit 98dba8a Feb 6, 2024
13 checks passed
@raskad raskad deleted the inline-caching-tests branch February 6, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execution Issues or PRs related to code execution vm Issues and PRs related to the Boa Virtual Machine. waiting-on-review Waiting on reviews from the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants