Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rust 1.75 lints #3540

Merged
merged 1 commit into from Dec 29, 2023
Merged

Fix rust 1.75 lints #3540

merged 1 commit into from Dec 29, 2023

Conversation

raskad
Copy link
Member

@raskad raskad commented Dec 29, 2023

This Pull Request changes the following:

  • Fix rust 1.75 lints

@raskad raskad added rust Pull requests that update Rust code Internal Category for changelog labels Dec 29, 2023
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 95,960 95,960 0
Passed 76,534 76,534 0
Ignored 18,477 18,477 0
Failed 949 949 0
Panics 0 0 0
Conformance 79.76% 79.76% 0.00%

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (1ef04a7) 48.83% compared to head (1971f6d) 47.42%.

Files Patch % Lines
...rser/expression/assignment/async_arrow_function.rs 0.00% 14 Missing ⚠️
...src/parser/expression/assignment/arrow_function.rs 20.00% 12 Missing ⚠️
core/runtime/src/console/mod.rs 0.00% 6 Missing ⚠️
.../src/builtins/iterable/async_from_sync_iterator.rs 0.00% 3 Missing ⚠️
cli/src/debug/function.rs 0.00% 2 Missing ⚠️
core/engine/src/builtins/typed_array/builtin.rs 0.00% 2 Missing ⚠️
core/engine/src/vm/flowgraph/graph.rs 0.00% 2 Missing ⚠️
core/temporal/src/components/duration.rs 0.00% 2 Missing ⚠️
cli/src/debug/object.rs 0.00% 1 Missing ⚠️
core/engine/src/module/synthetic.rs 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3540      +/-   ##
==========================================
- Coverage   48.83%   47.42%   -1.42%     
==========================================
  Files         470      470              
  Lines       48674    45690    -2984     
==========================================
- Hits        23769    21667    -2102     
+ Misses      24905    24023     -882     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raskad raskad requested a review from a team December 29, 2023 05:16
@raskad raskad added the waiting-on-review Waiting on reviews from the maintainers label Dec 29, 2023
Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@nekevss nekevss requested a review from a team December 29, 2023 05:39
@jedel1043 jedel1043 added this pull request to the merge queue Dec 29, 2023
Merged via the queue into main with commit 6ac435f Dec 29, 2023
14 checks passed
@raskad raskad deleted the rust-1.75 branch December 29, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Category for changelog rust Pull requests that update Rust code waiting-on-review Waiting on reviews from the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants