Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement getter for ArrayBuffer data #3610

Merged
merged 2 commits into from Jan 26, 2024
Merged

Conversation

HalidOdat
Copy link
Member

Implements .data() and .data_mut() for getting a reference to the internal byte data of ArrayBuffer without having to detach the buffer.

@HalidOdat HalidOdat added enhancement New feature or request API labels Jan 24, 2024
@HalidOdat HalidOdat added this to the v0.18.0 milestone Jan 24, 2024
@HalidOdat HalidOdat requested a review from a team January 24, 2024 16:15
Copy link

github-actions bot commented Jan 24, 2024

Test262 conformance changes

Test result main count PR count difference
Total 95,960 95,960 0
Passed 76,594 76,594 0
Ignored 18,477 18,477 0
Failed 889 889 0
Panics 0 0 0
Conformance 79.82% 79.82% 0.00%

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (ced2904) 47.44% compared to head (1bed26a) 47.43%.
Report is 2 commits behind head on main.

❗ Current head 1bed26a differs from pull request most recent head 308f78d. Consider uploading reports for the commit 308f78d to get more accurate results

Files Patch % Lines
core/engine/src/object/builtins/jsarraybuffer.rs 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3610      +/-   ##
==========================================
- Coverage   47.44%   47.43%   -0.02%     
==========================================
  Files         475      475              
  Lines       46036    46046      +10     
==========================================
  Hits        21841    21841              
- Misses      24195    24205      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HalidOdat HalidOdat force-pushed the feature/array-buffer-data-access branch from 49989fd to 1bed26a Compare January 24, 2024 16:25
@HalidOdat HalidOdat requested a review from a team January 25, 2024 08:46
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks perfect!

@jedel1043 jedel1043 requested a review from a team January 25, 2024 23:37
Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@nekevss nekevss added this pull request to the merge queue Jan 26, 2024
Merged via the queue into main with commit 9fb0f3c Jan 26, 2024
13 checks passed
@jedel1043 jedel1043 deleted the feature/array-buffer-data-access branch January 27, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants