Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve typing of DataView and related objects #3626

Merged
merged 1 commit into from Jan 30, 2024
Merged

Conversation

jedel1043
Copy link
Member

Just a small QOL change for DataView using the new non-erased JsObjects.

@jedel1043 jedel1043 added enhancement New feature or request technical debt labels Jan 29, 2024
@jedel1043 jedel1043 added this to the v0.18.0 milestone Jan 29, 2024
@jedel1043 jedel1043 requested a review from a team January 29, 2024 16:54
Copy link

github-actions bot commented Jan 29, 2024

Test262 conformance changes

Test result main count PR count difference
Total 95,960 95,960 0
Passed 79,714 79,714 0
Ignored 3,897 3,897 0
Failed 12,349 12,349 0
Panics 0 0 0
Conformance 83.07% 83.07% 0.00%

@raskad
Copy link
Member

raskad commented Jan 29, 2024

Looks like a really nice ergonomics improvement! Other than the warnings in the wasm build I have nothing to add :)

@jedel1043 jedel1043 force-pushed the non-erased-typed-arrays branch 2 times, most recently from 31add9f to 6844a08 Compare January 30, 2024 04:37
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 171 lines in your changes are missing coverage. Please review.

Comparison is base (34d0084) 47.43% compared to head (50b8f8a) 47.42%.

Files Patch % Lines
core/engine/src/object/builtins/jsdataview.rs 0.00% 35 Missing ⚠️
core/engine/src/builtins/array_buffer/mod.rs 0.00% 31 Missing ⚠️
core/engine/src/builtins/typed_array/object.rs 0.00% 24 Missing ⚠️
core/engine/src/builtins/typed_array/mod.rs 0.00% 23 Missing ⚠️
core/engine/src/object/jsobject.rs 0.00% 15 Missing ⚠️
.../engine/src/object/builtins/jssharedarraybuffer.rs 0.00% 14 Missing ⚠️
core/engine/src/builtins/typed_array/builtin.rs 0.00% 12 Missing ⚠️
core/engine/src/builtins/dataview/mod.rs 0.00% 6 Missing ⚠️
core/engine/src/builtins/array_buffer/shared.rs 0.00% 4 Missing ⚠️
core/engine/src/builtins/atomics/mod.rs 0.00% 4 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3626      +/-   ##
==========================================
- Coverage   47.43%   47.42%   -0.02%     
==========================================
  Files         476      476              
  Lines       46288    46307      +19     
==========================================
  Hits        21959    21959              
- Misses      24329    24348      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Happy to see us leveraging the type system! :)

@jedel1043 jedel1043 requested a review from a team January 30, 2024 10:20
@raskad raskad added this pull request to the merge queue Jan 30, 2024
Merged via the queue into main with commit 20dba13 Jan 30, 2024
14 checks passed
@jedel1043 jedel1043 deleted the non-erased-typed-arrays branch January 30, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants