Temporal: attribute/property and custom calendar fixes #3639

nekevss · 2024-01-31T12:12:13Z

This Pull Request mainly contains some small fixes to the attribute and properties on the Temporal built-ins, and updates the this value on the custom calendar method calls.

codecov · 2024-01-31T12:21:43Z

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (bb9d692) 47.27% compared to head (7b0226c) 47.30%.
Report is 2 commits behind head on main.

Files	Patch %	Lines
core/engine/src/builtins/temporal/calendar/mod.rs	3.57%	27 Missing ⚠️
core/temporal/src/components/date.rs	0.00%	2 Missing ⚠️
core/temporal/src/components/datetime.rs	0.00%	2 Missing ⚠️
...re/engine/src/builtins/temporal/calendar/object.rs	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3639      +/-   ##
==========================================
+ Coverage   47.27%   47.30%   +0.03%     
==========================================
  Files         476      476              
  Lines       46798    46828      +30     
==========================================
+ Hits        22123    22153      +30     
  Misses      24675    24675

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-01-31T12:33:16Z

Test262 conformance changes

Test result	main count	PR count	difference
Total	96,310	96,310	0
Passed	80,122	80,280	+158
Ignored	4,217	4,217	0
Failed	11,971	11,813	-158
Panics	0	0	0
Conformance	83.19%	83.36%	+0.16%

Fixed tests (158):

test/built-ins/Temporal/Duration/builtin.js [strict mode] (previously Failed)
test/built-ins/Temporal/Duration/builtin.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/minutes/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/Duration/prototype/minutes/prop-desc.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/weeks/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/Duration/prototype/weeks/prop-desc.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/sign/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/Duration/prototype/sign/prop-desc.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/months/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/Duration/prototype/months/prop-desc.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/nanoseconds/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/Duration/prototype/nanoseconds/prop-desc.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/toStringTag/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/Duration/prototype/toStringTag/prop-desc.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/microseconds/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/Duration/prototype/microseconds/prop-desc.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/blank/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/Duration/prototype/blank/prop-desc.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/milliseconds/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/Duration/prototype/milliseconds/prop-desc.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/hours/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/Duration/prototype/hours/prop-desc.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/seconds/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/Duration/prototype/seconds/prop-desc.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/days/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/Duration/prototype/days/prop-desc.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/years/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/Duration/prototype/years/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/builtin.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainYearMonth/builtin.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/year/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/year/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/inLeapYear/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/inLeapYear/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/toString/builtin-calendar-no-observable-calls.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/toString/builtin-calendar-no-observable-calls.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/toStringTag/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/toStringTag/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/toLocaleString/builtin-calendar-no-observable-calls.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/toLocaleString/builtin-calendar-no-observable-calls.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/daysInYear/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/daysInYear/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/monthsInYear/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/monthsInYear/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/calendarId/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/calendarId/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/monthCode/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/monthCode/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/daysInMonth/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/daysInMonth/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/month/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/month/prop-desc.js (previously Failed)
test/built-ins/Temporal/Instant/builtin.js [strict mode] (previously Failed)
test/built-ins/Temporal/Instant/builtin.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/builtin.js [strict mode] (previously Failed)
test/built-ins/Temporal/Instant/prototype/builtin.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/epochMicroseconds/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/Instant/prototype/epochMicroseconds/prop-desc.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/toStringTag/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/Instant/prototype/toStringTag/prop-desc.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/epochNanoseconds/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/Instant/prototype/epochNanoseconds/prop-desc.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/epochMilliseconds/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/Instant/prototype/epochMilliseconds/prop-desc.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/epochSeconds/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/Instant/prototype/epochSeconds/prop-desc.js (previously Failed)
test/built-ins/Temporal/TimeZone/builtin.js [strict mode] (previously Failed)
test/built-ins/Temporal/TimeZone/builtin.js (previously Failed)
test/built-ins/Temporal/TimeZone/prototype/toStringTag/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/TimeZone/prototype/toStringTag/prop-desc.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/builtin.js [strict mode] (previously Failed)
test/built-ins/Temporal/ZonedDateTime/builtin.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/toStringTag/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/toStringTag/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDate/builtin.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDate/builtin.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/weekOfYear/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/weekOfYear/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/daysInWeek/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/daysInWeek/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/year/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/year/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/inLeapYear/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/inLeapYear/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toString/builtin-calendar-no-observable-calls.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toString/builtin-calendar-no-observable-calls.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/day/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/day/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/dayOfYear/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/dayOfYear/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/dayOfYear/basic.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/dayOfYear/basic.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toStringTag/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toStringTag/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toLocaleString/builtin-calendar-no-observable-calls.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toLocaleString/builtin-calendar-no-observable-calls.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/daysInYear/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/daysInYear/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/monthsInYear/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/monthsInYear/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/calendarId/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/calendarId/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/calendarId/builtin-calendar-no-observable-calls.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/calendarId/builtin-calendar-no-observable-calls.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/monthCode/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/monthCode/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/yearOfWeek/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/yearOfWeek/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/dayOfWeek/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/dayOfWeek/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/daysInMonth/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/daysInMonth/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/month/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/month/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainTime/builtin.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainTime/builtin.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/microsecond/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/microsecond/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/toStringTag/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/toStringTag/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/second/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/second/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/nanosecond/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/nanosecond/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/minute/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/minute/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/millisecond/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/millisecond/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/builtin.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/builtin.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/weekOfYear/basic.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/weekOfYear/basic.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toString/builtin-calendar-no-observable-calls.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toString/builtin-calendar-no-observable-calls.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/dayOfYear/basic.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/dayOfYear/basic.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toStringTag/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toStringTag/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toLocaleString/builtin-calendar-no-observable-calls.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toLocaleString/builtin-calendar-no-observable-calls.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/monthsInYear/basic.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/monthsInYear/basic.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/calendarId/builtin-calendar-no-observable-calls.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/calendarId/builtin-calendar-no-observable-calls.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/yearOfWeek/basic.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/yearOfWeek/basic.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/dayOfWeek/basic.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/dayOfWeek/basic.js (previously Failed)
test/built-ins/Temporal/Calendar/builtin.js [strict mode] (previously Failed)
test/built-ins/Temporal/Calendar/builtin.js (previously Failed)
test/built-ins/Temporal/Calendar/prototype/id/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/Calendar/prototype/id/prop-desc.js (previously Failed)
test/built-ins/Temporal/Calendar/prototype/toStringTag/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/Calendar/prototype/toStringTag/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/builtin.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainMonthDay/builtin.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/prototype/toStringTag/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainMonthDay/prototype/toStringTag/prop-desc.js (previously Failed)

HalidOdat

Looks good to me! :)

nekevss added 4 commits January 31, 2024 06:52

Fix accessor attribute and toStringTag property

4e4cf44

Fix calendar methods and custom extends calendar calling

86412ef

Complete attribute update

68a6d88

run cargo fmt

7b0226c

nekevss added builtins PRs and Issues related to builtins/intrinsics waiting-on-review Waiting on reviews from the maintainers labels Jan 31, 2024

nekevss requested a review from a team January 31, 2024 13:15

nekevss added this to the v0.18.0 milestone Jan 31, 2024

HalidOdat approved these changes Jan 31, 2024

View reviewed changes

nekevss requested a review from a team January 31, 2024 14:39

raskad approved these changes Jan 31, 2024

View reviewed changes

raskad added this pull request to the merge queue Jan 31, 2024

Merged via the queue into main with commit 8f7028d Jan 31, 2024
14 checks passed

raskad deleted the temporal-builtin-fixes branch January 31, 2024 20:28

HalidOdat mentioned this pull request Feb 28, 2024

initial changelog for v0.18 #3691

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Temporal: attribute/property and custom calendar fixes #3639

Temporal: attribute/property and custom calendar fixes #3639

nekevss commented Jan 31, 2024

codecov bot commented Jan 31, 2024 •

edited

github-actions bot commented Jan 31, 2024

HalidOdat left a comment

Temporal: attribute/property and custom calendar fixes #3639

Temporal: attribute/property and custom calendar fixes #3639

Conversation

nekevss commented Jan 31, 2024

codecov bot commented Jan 31, 2024 • edited

Codecov Report

github-actions bot commented Jan 31, 2024

Test262 conformance changes

HalidOdat left a comment

Choose a reason for hiding this comment

codecov bot commented Jan 31, 2024 •

edited