Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Promise.try() #3800

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Implement Promise.try() #3800

merged 1 commit into from
Apr 10, 2024

Conversation

linusg
Copy link
Contributor

@linusg linusg commented Apr 9, 2024

Stage 2.7 as of yesterday. See: https://github.com/tc39/proposal-promise-try

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! @linusg

Just a small nitpick :)

core/engine/src/builtins/promise/mod.rs Outdated Show resolved Hide resolved
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 5.00000% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 50.20%. Comparing base (6ddc2b4) to head (0789605).
Report is 127 commits behind head on main.

Files Patch % Lines
core/engine/src/builtins/promise/mod.rs 5.00% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3800      +/-   ##
==========================================
+ Coverage   47.24%   50.20%   +2.96%     
==========================================
  Files         476      456      -20     
  Lines       46892    44842    -2050     
==========================================
+ Hits        22154    22515     +361     
+ Misses      24738    22327    -2411     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect! Thank you for the contribution :)

@jedel1043 jedel1043 requested review from a team and HalidOdat April 9, 2024 19:06
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@HalidOdat HalidOdat added this pull request to the merge queue Apr 10, 2024
Merged via the queue into boa-dev:main with commit c0a961f Apr 10, 2024
14 checks passed
@linusg linusg deleted the promise-try branch April 10, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants