Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure tests test error type #563

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Conversation

joshwd36
Copy link
Contributor

This Pull Request ensures tests that catch errors are testing the error type as well as just the message, as mentioned in this PR.

@codecov
Copy link

codecov bot commented Jul 13, 2020

Codecov Report

Merging #563 into master will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #563      +/-   ##
==========================================
+ Coverage   69.30%   69.37%   +0.07%     
==========================================
  Files         172      172              
  Lines       10580    10580              
==========================================
+ Hits         7332     7340       +8     
+ Misses       3248     3240       -8     
Impacted Files Coverage Δ
boa/src/builtins/bigint/tests.rs 100.00% <100.00%> (ø)
boa/src/builtins/object/tests.rs 100.00% <100.00%> (ø)
boa/src/exec/operator/tests.rs 100.00% <100.00%> (ø)
boa/src/exec/tests.rs 100.00% <100.00%> (ø)
boa/src/builtins/error/type.rs 76.19% <0.00%> (+19.04%) ⬆️
boa/src/builtins/error/reference.rs 76.19% <0.00%> (+19.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffe8b5f...903178f. Read the comment docs.

@HalidOdat HalidOdat added enhancement New feature or request test Issues and PRs related to the tests. labels Jul 13, 2020
@HalidOdat HalidOdat added this to the v0.10.0 milestone Jul 13, 2020
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks! :)

@Razican Razican merged commit df80ee0 into boa-dev:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants