Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All Expression Nodes Evaluate #649

Closed
wants to merge 3 commits into from
Closed

All Expression Nodes Evaluate #649

wants to merge 3 commits into from

Conversation

jcdickinson
Copy link
Contributor

@jcdickinson jcdickinson commented Aug 20, 2020 •
edited

This Pull Request fixes/closes #647 and closes #648.

It changes the following:

  • Adds support for continue
  • Adds support for ternary conditionals
  • Adds tests for both of the above

@jcdickinson jcdickinson changed the title Allnodes All Expression Nodes Evaluate Aug 20, 2020
@jcdickinson
Copy link
Contributor Author

Currently failing for the same reason as master.

@Razican Razican added bug Something isn't working execution Issues or PRs related to code execution labels Aug 20, 2020
@Razican Razican added this to the v0.10.0 milestone Aug 20, 2020
@jcdickinson
Copy link
Contributor Author

This has already been completed by #635. Closing this PR.

@Razican Razican added the duplicate This issue or pull request already exists label Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working duplicate This issue or pull request already exists execution Issues or PRs related to code execution
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.

Continue Panics Ternary Conditionals Panic
2 participants
@jcdickinson @Razican