Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JSON stringification for fractional numbers #870

Merged
merged 1 commit into from Oct 14, 2020
Merged

Fix JSON stringification for fractional numbers #870

merged 1 commit into from Oct 14, 2020

Conversation

georgeroman
Copy link
Contributor

Fixes #449

@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #870 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #870      +/-   ##
==========================================
+ Coverage   59.03%   59.09%   +0.05%     
==========================================
  Files         164      164              
  Lines       10217    10216       -1     
==========================================
+ Hits         6032     6037       +5     
+ Misses       4185     4179       -6
Impacted Files Coverage Δ
boa/src/value/mod.rs 73.78% <100.00%> (+0.73%) ⬆️
...x/parser/statement/iteration/do_while_statement.rs 73.91% <0.00%> (+13.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6834f7b...2079c4f. Read the comment docs.

@Razican Razican added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics execution Issues or PRs related to code execution labels Oct 14, 2020
@Razican Razican added this to the v0.11.0 milestone Oct 14, 2020
Razican
Razican approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@Razican Razican left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks :D

Build issues seem unrelated, and only happen with MacOS, not sure why.

@HalidOdat HalidOdat merged commit a48a2e6 into boa-dev:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Razican Razican Razican approved these changes

@HalidOdat HalidOdat HalidOdat approved these changes

@RageKnify RageKnify RageKnify approved these changes

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

@Lan2u Lan2u Awaiting requested review from Lan2u

Assignees
No one assigned
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics execution Issues or PRs related to code execution
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.

JSON.stringify sometimes changes values from int to float
4 participants
@georgeroman @Razican @HalidOdat @RageKnify