Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exec Map] Map.prototype.values and Map.prototype.keys implementation #874

Merged
merged 13 commits into from Oct 15, 2020

Conversation

croraf
Copy link
Contributor

@croraf croraf commented Oct 14, 2020

This Pull Request closes #845

The number of changes is effectively small, but depends on #847 being merged first. Will do the merge of master after that.

@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #874 into master will increase coverage by 0.04%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #874      +/-   ##
==========================================
+ Coverage   59.17%   59.22%   +0.04%     
==========================================
  Files         165      165              
  Lines       10284    10290       +6     
==========================================
+ Hits         6086     6094       +8     
+ Misses       4198     4196       -2     
Impacted Files Coverage Δ
boa/src/builtins/map/mod.rs 72.26% <66.66%> (-0.26%) ⬇️
boa/src/builtins/map/map_iterator.rs 71.42% <0.00%> (+7.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce535dd...21a2af5. Read the comment docs.

@Lan2u Lan2u merged commit 5ac5b5d into boa-dev:master Oct 15, 2020
@RageKnify RageKnify added this to the v0.11.0 milestone Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map.prototype.values() method not implemented
3 participants