Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Unicode character escape sequence parsing #959

Merged
merged 2 commits into from Dec 11, 2020
Merged

Fix Unicode character escape sequence parsing #959

merged 2 commits into from Dec 11, 2020

Conversation

tofpie
Copy link
Contributor

@tofpie tofpie commented Dec 11, 2020

This Pull Request fixes #827.

It changes the following:

  • Parsing of Unicode escape sequences
  • Lexer tests

This fixes issue #827 on parsing Unicode escape sequence with curly
braces.
@codecov
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #959 (1f6119b) into master (98e11d7) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #959      +/-   ##
==========================================
+ Coverage   59.29%   59.32%   +0.02%     
==========================================
  Files         166      166              
  Lines       10689    10687       -2     
==========================================
+ Hits         6338     6340       +2     
+ Misses       4351     4347       -4     
Impacted Files Coverage Δ
boa/src/syntax/lexer/string.rs 38.09% <ø> (-1.44%) ⬇️
boa/src/syntax/lexer/mod.rs 68.46% <0.00%> (+3.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98e11d7...80e3776. Read the comment docs.

@Razican Razican added bug Something isn't working lexer Issues surrounding the lexer labels Dec 11, 2020
@Razican Razican added this to the v0.11.0 milestone Dec 11, 2020
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Looks very good to me, let's merge :)

@Razican Razican merged commit 6d866f8 into boa-dev:master Dec 11, 2020
@Razican
Copy link
Member

Razican commented Dec 11, 2020

For posterity's sake, here we have the results of the test262 test suite. Surprisingly, there are no tests for this (or there is something we are missing):

Test262 conformance changes:

Test result master count PR count difference
Total 78,460 78,460 0
Passed 18,964 18,964 0
Ignored 15,559 15,559 0
Failed 43,937 43,937 0
Panics 1,127 1,127 0
Conformance 24.17 24.17 0.00%

@tofpie tofpie deleted the fix-827 branch December 17, 2020 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lexer Issues surrounding the lexer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syntax error when using Unicode escape sequence with curly brackets in a string
3 participants